tisonkun opened a new pull request, #539: URL: https://github.com/apache/casbin-jcasbin/pull/539
Registering a role-name matcher through `addNamedMatchingFunc` throws `ClassCastException` for conditional role managers. Registering it directly rebuilds the graph without condition functions or parameters, so a previously denied request can become allowed. Dispatch to the supported role-manager implementations and rebuild conditional role graphs from explicit links while retaining all condition metadata, including conditions registered before their links. Regression tests exercise named roles with and without domains, repeated matcher registration, matcher replacement, parameter updates, and effective pattern matching. Validation: - Java 8 (Zulu 8u482), Maven 3.9.12: `mvn -B -ntp clean verify cobertura:cobertura -Papache-release -Drevision=1.100.0 -Dgpg.skip=true` passed all 350 tests with zero failures, errors, or skips, including conformance inputs pinned to `apache/casbin@c35c93d29063b8bc3bc2ef30b09943d344a289f4`. - All five new regression cases fail on the original implementation and pass with the fix. - Apache RAT 0.18 and all 11 release-verification Python tests pass. Cobertura still emits the existing source-parser diagnostics while calculating complexity; the build exits successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
