AemieJ commented on a change in pull request #398:
URL: https://github.com/apache/camel-website/pull/398#discussion_r442297448
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -131,11 +131,14 @@
--footer-height: 23rem; /* empirically corresponding current design of the
foooter */
/* dimensions */
--navbar-height: calc(73 / var(--rem-base) * 1rem);
+ --toolbar-nav-height: calc(139.5 / var(--rem-base) * 1rem);
+ --panel-height: calc(54 / var(--rem-base) * 1rem);
Review comment:
Alright, the toolbar nav height is introduced for the width < 1275 as we
introduce the whole search design below the actual navbar including the logo
and social icons.
Now with the changes, I observed that within the menu panel height under the
docs section, the panel items overflow to the footer due to the height defined.
Hence, the panel height is used to prevent the overflow.
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -131,11 +131,14 @@
--footer-height: 23rem; /* empirically corresponding current design of the
foooter */
/* dimensions */
--navbar-height: calc(73 / var(--rem-base) * 1rem);
+ --toolbar-nav-height: calc(139.5 / var(--rem-base) * 1rem);
+ --panel-height: calc(54 / var(--rem-base) * 1rem);
Review comment:
Alright, the toolbar nav height is introduced for the width < 1275 as we
introduce the whole search design below the actual navbar including the logo
and social icons.
Now with the changes, I observed that within the menu panel height under the
docs section, the panel items overflow to the footer due to the height defined.
Hence, the panel height is used to prevent the overflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
