jamesnetherton commented on a change in pull request #1338:
URL: https://github.com/apache/camel-quarkus/pull/1338#discussion_r438757214
##########
File path:
integration-tests/http/src/main/java/org/apache/camel/quarkus/component/http/it/HttpResource.java
##########
@@ -155,8 +155,9 @@ public String nettyHttpGet(@QueryParam("test-port") int
port) {
@GET
@Produces(MediaType.TEXT_PLAIN)
public String nettyHttpGetHttps() {
+ // String truststore =
System.getProperty("javax.net.ssl.trustStore");
Review comment:
Lets remove if not needed.
##########
File path: integration-tests/http/src/main/resources/jsse/readme.adoc
##########
@@ -0,0 +1,4 @@
+Server keystore has to contain server certificate. It is possible to use
self-signed certificate created by following command:
+
+`keytool -genkeypair -keystore keystore.p12 -storetype PKCS12 -storepass
changeit -alias localhost -keyalg RSA -keysize 2048 -validity 99999 -dname
"CN=localhost"
+.crt.pem -storetype JKS -keystore server.truststore -storepass changeit`
Review comment:
Can you keep the README in the root of `integration-tests/http` instead
of in the `resources` directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
