This is an automated email from the ASF dual-hosted git repository. orpiske pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit 2e43d28ec3bbd7a6abe633313e54149a01c6f84c Author: Otavio Rodolfo Piske <[email protected]> AuthorDate: Fri Feb 6 13:02:04 2026 +0000 (chores): modernize instanceof checks in camel-support --- .../src/main/java/org/apache/camel/support/LoggerHelper.java | 8 ++++---- .../src/main/java/org/apache/camel/support/ObjectHelper.java | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/core/camel-support/src/main/java/org/apache/camel/support/LoggerHelper.java b/core/camel-support/src/main/java/org/apache/camel/support/LoggerHelper.java index a2258b4b8846..a167ba8dea85 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/LoggerHelper.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/LoggerHelper.java @@ -95,13 +95,13 @@ public final class LoggerHelper { public static String getSourceLocationOnly(Object node) { String name = null; - if (node instanceof LineNumberAware) { - if (node instanceof NamedRoute namedRoute) { + if (node instanceof LineNumberAware lna) { + LineNumberAware lineNumberAware = lna; + if (lna instanceof NamedRoute namedRoute) { // we want the input from a route as it has the source location / line number - node = namedRoute.getInput(); + lineNumberAware = (LineNumberAware) namedRoute.getInput(); } - final LineNumberAware lineNumberAware = (LineNumberAware) node; String loc = lineNumberAware.getLocation(); if (loc != null) { // is it a class or file? diff --git a/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java b/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java index 85dab79a5b39..a5acef72f256 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java @@ -292,13 +292,13 @@ public final class ObjectHelper { Long rightNum = Long.valueOf((String) rightValue); return leftNum.compareTo(rightNum); } - } else if (rightValue instanceof Double rightNum && leftValue instanceof String - && isFloatingNumber((String) leftValue)) { - Double leftNum = Double.valueOf((String) leftValue); + } else if (rightValue instanceof Double rightNum && leftValue instanceof String leftStr + && isFloatingNumber(leftStr)) { + Double leftNum = Double.valueOf(leftStr); return leftNum.compareTo(rightNum); - } else if (rightValue instanceof Float rightNum && leftValue instanceof String - && isFloatingNumber((String) leftValue)) { - Float leftNum = Float.valueOf((String) leftValue); + } else if (rightValue instanceof Float rightNum && leftValue instanceof String leftStr + && isFloatingNumber(leftStr)) { + Float leftNum = Float.valueOf(leftStr); return leftNum.compareTo(rightNum); } else if (rightValue instanceof Boolean rightBool && leftValue instanceof String) { Boolean leftBool = Boolean.valueOf((String) leftValue);
