Megha-Megha13 commented on code in PR #21255:
URL: https://github.com/apache/camel/pull/21255#discussion_r2768019125
##########
test-infra/camel-test-infra-keycloak/src/main/java/org/apache/camel/test/infra/keycloak/services/KeycloakLocalContainerInfraService.java:
##########
@@ -70,12 +71,20 @@ class TestInfraKeycloakContainer extends
GenericContainer<TestInfraKeycloakConta
public TestInfraKeycloakContainer(boolean fixedPort) {
super(DockerImageName.parse(keycloakImage));
- withExposedPorts(KEYCLOAK_PORT)
- .withEnv("KEYCLOAK_ADMIN", DEFAULT_ADMIN_USERNAME)
- .withEnv("KEYCLOAK_ADMIN_PASSWORD",
DEFAULT_ADMIN_PASSWORD)
- .withCommand("start-dev")
- .waitingFor(Wait.forListeningPorts(KEYCLOAK_PORT))
- .withStartupTimeout(Duration.ofMinutes(3L));
+ if ("ppc64le".equals(SystemUtils.OS_ARCH))
+ withExposedPorts(KEYCLOAK_PORT)
+ .withEnv("KEYCLOAK_ADMIN", DEFAULT_ADMIN_USERNAME)
+ .withEnv("KEYCLOAK_ADMIN_PASSWORD",
DEFAULT_ADMIN_PASSWORD)
+ .withCommand("/opt/bitnami/keycloak/bin/kc.sh",
"start-dev")
+ .waitingFor(Wait.forListeningPorts(KEYCLOAK_PORT))
+ .withStartupTimeout(Duration.ofMinutes(3L));
+ else
+ withExposedPorts(KEYCLOAK_PORT)
+ .withEnv("KEYCLOAK_ADMIN", DEFAULT_ADMIN_USERNAME)
+ .withEnv("KEYCLOAK_ADMIN_PASSWORD",
DEFAULT_ADMIN_PASSWORD)
+ .withCommand("start-dev")
+ .waitingFor(Wait.forListeningPorts(KEYCLOAK_PORT))
+ .withStartupTimeout(Duration.ofMinutes(3L));
Review Comment:
Thank you for the suggestion.
I agree with your point. I’ll refactor the code so the architecture check
determines only the command string, while the rest of the container setup is
shared. This removes duplication and keeps the logic cleaner.
I’ll push the updated patch shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
