mcarlett commented on code in PR #21143:
URL: https://github.com/apache/camel/pull/21143#discussion_r2741631761
##########
test-infra/camel-test-infra-cli/src/test/java/org/apache/camel/test/infra/cli/services/CliBuiltContainer.java:
##########
@@ -223,5 +230,23 @@ public CliBuiltContainerParams setDockerFile(String
dockerFile) {
this.dockerFile = dockerFile;
return this;
}
+
+ public String getMainCommand() {
+ return mainCommand;
+ }
+
+ public CliBuiltContainerParams setMainCommand(String mainCommand) {
+ this.mainCommand = mainCommand;
+ return this;
+ }
+
+ public String getCamelLauncher() {
+ return camelLauncher;
+ }
+
+ public CliBuiltContainerParams setCamelLauncher(String camelLauncher) {
+ this.camelLauncher = camelLauncher;
+ return this;
+ }
Review Comment:
are those methods used in camel-test-infra-cli? if not maybe you can use
this as parameter just in the IT module (camel-jbang-it) , it is easier and the
context is correct
##########
test-infra/camel-test-infra-cli/src/test/java/org/apache/camel/test/infra/cli/common/CliProperties.java:
##########
@@ -21,6 +21,10 @@ public final class CliProperties {
public static final String DOCKERFILE = "cli.service.docker.file";
+ public static final String MAIN_COMMAND = "cli.service.command";
+
+ public static final String CAMEL_LAUNCHER = "cli.service.camel.launcher";
Review Comment:
as for the methods, I think we should use a simple system property in
camel-jbang-it module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
