cunningt opened a new pull request, #19395: URL: https://github.com/apache/camel/pull/19395
# Description `dsl/camel-jbang/camel-jbang-core/src/main/java-templates/org/apache/camel/dsl/jbang/core/common/RuntimeType.java ` has hardcoded versions of quarkus and spring-boot included in it that are hard to maintain - they won't be picked up by dependabot updates. This is an attempt to manage the spring-boot / quarkus versions for RuntimeType.java consistently with how camel manages other third party versions - add them to parent/pom.xml, and then filter the versions into the source. Looking for some feedback here - this compiles with no issues for me locally - templating-maven-plugin is executed pre-compile in maven, but I am not sure how IDEs will handle this. References to RuntimeType might be marked as missing, I'm not sure if IDEs know to look in the `java-templates` directory for sources. Another strategy might be to filter the versions into a property file and then read that file in RuntimeType for the quarkus/spring-boot versions - I could change to that if that's preferable? # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. - [x] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
