apupier commented on code in PR #15717:
URL: https://github.com/apache/camel/pull/15717#discussion_r1776686375


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_8.adoc:
##########
@@ -32,7 +32,7 @@ if the parameter `includeProperties` is set to true.
 
 The `camel trace` command has changed to show tracing status (by default). To 
dump traced messages use `camel trace --action=dump`.
 
-*Breaking changes* The parameter `--repos` has been renamed `--repository` for 
`run` and `export` commands. It requires to be updated when using from 
command-line and in `application.properties`.
+*Breaking changes only in 4.8.0* The parameter `--repos` has been renamed 
`--repository` for `run` and `export` commands. It requires to be updated when 
using from command-line and in `application.properties`. In 4.8.1, the 
`--repos` has been set back and  `--repository` removed.

Review Comment:
   It implies the removal of an option from a LTS version  but given that:
   * it was introduced just for this version
   * it was broken for several cases
   * changes were not applied to other commands than run and export, meaning it 
was not coherent across commands
   * to apply allow changes
   * it was initially done in an effort to be able to provide parameter using 
style `--repository=xxx --repository=yyy` instead of `--repository=xxx,yyy` but 
it was already reverted during 4.8 development
   I hope it can be acceptable to break again the Camel JBang command-line API 
and get back to previous state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to