davsclaus commented on code in PR #1389:
URL: https://github.com/apache/camel-karavan/pull/1389#discussion_r1737057814
##########
karavan-app/src/main/resources/configuration/kubernetes/build.sh:
##########
@@ -13,7 +13,7 @@ git clone --depth 1 --branch $GIT_BRANCH $GIT_REPOSITORY
$CODE_DIR
cd $CODE_DIR/$PROJECT_ID
-jbang -Dcamel.jbang.version=$CAMEL_VERSION camel@apache/camel export
--local-kamelet-dir=$KAMELETS_DIR
+jbang -Dcamel.jbang.version=$CAMEL_VERSION camel@apache/camel export
--local-kamelet-dir=$KAMELETS_DIR --runtime=${CAMEL_JBANG_RUNTIME:-camel-main}
Review Comment:
This ENV var would allow to control the runtime of choice so its IMHO fine
to keep.
But karavan also have docker build scripts so I think changes in this PR
should also be looked at in Docker and do something there also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
