jakubmalek commented on PR #14926: URL: https://github.com/apache/camel/pull/14926#issuecomment-2247933461
I've changed the executor to be created via `ExecutorServiceManager` bean. I wasn't sure about `java.time.Clock` bean, there is a `org.apache.camel.clock.Clock` but it provides uptime since exchange creation instead of current system time. In general I could use this time as reference point to measure time elapsed but I wasn't sure if this the right bean for that. I'm not sure about the point of not encapsulating client. Do you mean that the logic should be part of `Sqs2Consumer` class ? In general I wanted to have a separated class as its tested more easily and the consumer class is quite large already. But if its the preferred way I can adjust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
