christophd commented on code in PR #14808:
URL: https://github.com/apache/camel/pull/14808#discussion_r1677434575
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ExportBaseCommand.java:
##########
@@ -94,8 +94,8 @@ public abstract class ExportBaseCommand extends CamelCommand {
protected String repos;
@CommandLine.Option(names = {
- "--dep", "--deps" }, description = "Add additional dependencies
(Use commas to separate multiple dependencies).")
- protected String dependencies;
+ "--dep", "--deps" }, arity = "*", description = "Add additional
dependencies")
+ private String[] _dependencies; // [TODO] make less protected when we
ditch --deps
Review Comment:
What prevents us from ditching `--deps` right away to avoid these TODOs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
