Croway commented on PR #132:
URL: 
https://github.com/apache/camel-spring-boot-examples/pull/132#issuecomment-2162788074

   > I generally prefer to name keys with `myXXX` or something like `beer`, 
`donald-duck` or something to make it very obvious its something you can type 
anything, and not some "fixed" special value you must use.
   > 
   > so its not so easy to know if `database` can be any value you want, and so 
on.
   
   I am a bit confused, do you refer to 
https://github.com/apache/camel-spring-boot-examples/pull/132/files#diff-bf2471b4f919f5dae04106e4d34966dd292c9a3d30e92eb8bca76952e564a0fbR12
 ? should I rename those to myDatabase, myUsername and so on? Do you think it 
will be more clear?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to