gansheer commented on code in PR #5581:
URL: https://github.com/apache/camel-k/pull/5581#discussion_r1627149760
##########
e2e/advanced/maven_http_proxy_test.go:
##########
@@ -210,10 +210,15 @@ func TestMavenProxy(t *testing.T) {
g.Expect(err).To(Succeed())
g.Expect(proxies.Items).To(HaveLen(1))
+ ocp, err := openshift.IsOpenShift(TestClient(t))
+ require.NoError(t, err)
+
logs := Logs(t, ctx, ns, proxies.Items[0].Name,
corev1.PodLogOptions{})()
g.Expect(logs).NotTo(BeEmpty())
- g.Expect(logs).To(ContainSubstring("\"CONNECT
repo.maven.apache.org:443 HTTP/1.1\" 200"))
-
+ if !ocp {
+ // OpenShift has internal configuration (like oauth)
that overriddes the default repo connect URL
+ g.Expect(logs).To(ContainSubstring("\"CONNECT
repo.maven.apache.org:443 HTTP/1.1\" 200"))
Review Comment:
I removed the check but kept the passing test. I think proof of build with
the proxy present goes by hand with the build error without the proxy. The
proxy being test code driven makes it less infra dependant.
But if you think it is too much to maintain I can remove it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
