oscerd commented on code in PR #14274:
URL: https://github.com/apache/camel/pull/14274#discussion_r1618645686


##########
components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Endpoint.java:
##########
@@ -64,6 +63,30 @@ public AWS2S3Endpoint(String uri, Component comp, 
AWS2S3Configuration configurat
         this.configuration = configuration;
     }
 
+    @Override
+    public String getServiceUrl() {
+        if (!configuration.isOverrideEndpoint()) {
+            return configuration.getBucketName() + "." + getServiceProtocol() 
+ ".amazonaws.com";

Review Comment:
   and this is how it will look
   
   ```
   jbang -Dcamel.jbang.version=4.7.0-SNAPSHOT camel@apache/camel get service 
--metadata
     PID   NAME           COMPONENT  DIR  PROTOCOL  SERVICE                     
    METADATA          TOTAL  ENDPOINT                                           
                                      
    46780  aws-s3-to-log  aws2-s3    in   s3        
kamelets-demo.s3.amazonaws.com  region=eu-west-1      0  
aws2-s3://kamelets-demo?accessKey=xxxxxx&autoCreateBucket=false&delay=500&deleteAfterRe…
 
    46780  aws-s3-to-log  aws2-s3    out  s3        
kamelets-demo.s3.amazonaws.com  region=eu-west-1      0  
aws2-s3://kamelets-demo?accessKey=xxxxxx&autoCreateBucket=false&delay=500&deleteAfterRe…
 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to