squakez opened a new pull request, #5524:
URL: https://github.com/apache/camel-k/pull/5524

   <!-- Description -->
   
   #5378 had introduced a regression on certain traits that were expecting the 
presence of a Camel Catalog in order to work. These traits can still work using 
the legacy business logic which were expecting Camel Quarkus as a runtime. 
These PR amend that behavior and requires the introduction of new parameters 
for the health trait in order to let the user explicitly configure the path for 
the different probes we offer.
   
   Knative and KnativeService traits would require the user to forcefully set 
`enabled=true` and `auto=false` in order to let the operator know to skip any 
check which would require the presence of a catalog, making them work also when 
a catalog is absent (ie, "sourceless" Integrations).
   
   Notice that the health probes are necessarily part of the runtime 
specification as they are runtime detail specific (ie, Quarkus probes differ 
from Springboot probes), therefore, in absence of a catalog, it seems to be the 
best option to let the user specify the probes path to use. This is defaulting 
to Quarkus legacy, so it won't require immediate attention by users upgrading. 
However it's advisable to switch to a new explicit logic as soon as possible as 
using those default is deprecated and will be removed soon.
   
   For logging, we are defaulting to the Quarkus runtime, but it's also 
advisable to move soon to an explicit logic where the catalog is missing (ie, 
setting explicitly the logging camel properties).
   
   Closes #5519 
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" 
to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   fix(trait): camel catalog regression
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to