lburgazzoli commented on code in PR #5480:
URL: https://github.com/apache/camel-k/pull/5480#discussion_r1594186066
##########
pkg/util/maven/maven_command.go:
##########
@@ -185,7 +185,7 @@ func (c *Context) AddSystemProperty(name string, value
string) {
c.AddArgumentf("-D%s=%s", name, value)
}
-func generateProjectStructure(context Context, project Project) error {
+func generateProjectStructure(context Context, project *Project) error {
Review Comment:
The opposite, this way we are passing a pointer so no copy is performed when
invoking this method but I reverted it as it is enough to pass by value in this
case. It was a leftover of a change to make the methods on the `Project` struct
consistently using pointer receiver instead of a mix of pointer and value
receivers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
