christophd commented on code in PR #5419:
URL: https://github.com/apache/camel-k/pull/5419#discussion_r1579135921
##########
pkg/trait/knative_service.go:
##########
@@ -149,6 +150,11 @@ func (t *knativeServiceTrait) SelectControllerStrategy(e
*Environment) (*Control
return nil, nil
}
+ // Knative serving is required
+ if ok, _ := knative.IsServingInstalled(e.Client); !ok {
Review Comment:
but the controller strategy selector is a totally different interface. The
`Configure()` already evaluates the controller strategy to skip the trait when
the strategy is not Knative. Apart from that we need to make sure that the
controller strategy is only Knative when Serving is installed as the interface
can be used also when the trait is disabled. This is why I put this into the
controller strategy selector interface implementation part of the trait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
