squakez commented on code in PR #5370:
URL: https://github.com/apache/camel-k/pull/5370#discussion_r1576274477
##########
e2e/common/misc/cron_test.go:
##########
@@ -45,13 +45,6 @@ func TestRunCronExample(t *testing.T) {
g.Eventually(SelectedPlatformPhase(t, ctx, ns, operatorID),
TestTimeoutMedium).Should(Equal(v1.IntegrationPlatformPhaseReady))
- t.Run("cron", func(t *testing.T) {
Review Comment:
Why removing this test?
##########
e2e/common/misc/pipe_test.go:
##########
@@ -38,6 +40,12 @@ import (
func TestPipe(t *testing.T) {
t.Parallel()
+ // [TODO] Enable arm64 smoke tests to run out of the box
+ // https://github.com/apache/camel-k/issues/5362
+ if runtime.GOARCH == "arm64" && os.Getenv("CAMEL_K_TEST_BASE_IMAGE") ==
"" {
+ t.Skipf("TestPipe not supported on platform: %s/%s",
runtime.GOOS, runtime.GOARCH)
Review Comment:
Why is this test not supported? I don't think it should fail whichever the
platform running it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
