squakez commented on code in PR #5350:
URL: https://github.com/apache/camel-k/pull/5350#discussion_r1559456386
##########
pkg/install/operator.go:
##########
@@ -145,7 +145,9 @@ func OperatorOrCollect(ctx context.Context, cmd
*cobra.Command, c client.Client,
fmt.Fprintln(cmd.ErrOrStderr(),
"Warning: could not parse environment variables!")
}
for i := 0; i <
len(d.Spec.Template.Spec.Containers); i++ {
-
d.Spec.Template.Spec.Containers[i].Env =
append(d.Spec.Template.Spec.Containers[i].Env, envVars...)
+ for _, envVar := range envVars {
+
envvar.SetVar(&d.Spec.Template.Spec.Containers[i].Env, envVar)
Review Comment:
Is this func taking care to check if the envvar already exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
