This is an automated email from the ASF dual-hosted git repository. orpiske pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit 3fedbc8c9d08056480358d551d9428e3b9f7b9a6 Author: Otavio Rodolfo Piske <[email protected]> AuthorDate: Tue Apr 9 17:00:06 2024 +0200 (chores) camel-core: removed and/or fixed redundant suppressions --- .../java/org/apache/camel/impl/debugger/DefaultBacklogDebugger.java | 2 +- .../org/apache/camel/impl/engine/DefaultRuntimeEndpointRegistry.java | 1 - .../src/main/java/org/apache/camel/builder/DataFormatClause.java | 1 - .../src/main/java/org/apache/camel/model/DataFormatDefinition.java | 1 - .../src/main/java/org/apache/camel/model/RouteDefinitionHelper.java | 2 +- .../java/org/apache/camel/model/app/BeanConstructorsAdapter.java | 1 - .../main/java/org/apache/camel/model/config/ResequencerConfig.java | 1 - .../src/main/java/org/apache/camel/model/rest/RestDefinition.java | 1 - .../org/apache/camel/processor/aggregate/AggregateProcessor.java | 1 - .../src/test/java/org/apache/camel/builder/ExceptionBuilderTest.java | 1 - .../camel/processor/onexception/OnExceptionMisconfiguredTest.java | 5 ----- .../apache/camel/processor/onexception/OnExceptionsPerRouteTest.java | 1 - .../org/apache/camel/management/DefaultManagementObjectStrategy.java | 4 ---- .../src/main/java/org/apache/camel/support/ObjectHelper.java | 2 +- 14 files changed, 3 insertions(+), 21 deletions(-) diff --git a/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultBacklogDebugger.java b/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultBacklogDebugger.java index c53a16d3405..1a1ca5cf83c 100644 --- a/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultBacklogDebugger.java +++ b/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultBacklogDebugger.java @@ -1012,7 +1012,6 @@ public final class DefaultBacklogDebugger extends ServiceSupport implements Back } @Override - @SuppressWarnings("unchecked") public void onEvent(Exchange exchange, ExchangeEvent event, NamedNode definition) { if (event instanceof ExchangeCompletedEvent || event instanceof CamelEvent.ExchangeFailedEvent) { Throwable cause = null; @@ -1033,6 +1032,7 @@ public final class DefaultBacklogDebugger extends ServiceSupport implements Back } } + @SuppressWarnings("unchecked") private NamedRoute getOriginalRoute(Exchange exchange) { List<MessageHistory> list = exchange.getProperty(ExchangePropertyKey.MESSAGE_HISTORY, List.class); if (list != null) { diff --git a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultRuntimeEndpointRegistry.java b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultRuntimeEndpointRegistry.java index f3748e91ce9..bcc5cc6592a 100644 --- a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultRuntimeEndpointRegistry.java +++ b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultRuntimeEndpointRegistry.java @@ -211,7 +211,6 @@ public class DefaultRuntimeEndpointRegistry extends EventNotifierSupport impleme } @Override - @SuppressWarnings("unchecked") public void notify(CamelEvent event) throws Exception { if (event instanceof RouteAddedEvent) { RouteAddedEvent rse = (RouteAddedEvent) event; diff --git a/core/camel-core-model/src/main/java/org/apache/camel/builder/DataFormatClause.java b/core/camel-core-model/src/main/java/org/apache/camel/builder/DataFormatClause.java index 16037efba3a..b772e72041d 100644 --- a/core/camel-core-model/src/main/java/org/apache/camel/builder/DataFormatClause.java +++ b/core/camel-core-model/src/main/java/org/apache/camel/builder/DataFormatClause.java @@ -1453,7 +1453,6 @@ public class DataFormatClause<T extends ProcessorDefinition<?>> { return this; } - @SuppressWarnings("unchecked") private T dataFormat(DataFormatDefinition dataFormatType) { switch (operation) { case Unmarshal: diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/DataFormatDefinition.java b/core/camel-core-model/src/main/java/org/apache/camel/model/DataFormatDefinition.java index ddce36d44e2..086e316c603 100644 --- a/core/camel-core-model/src/main/java/org/apache/camel/model/DataFormatDefinition.java +++ b/core/camel-core-model/src/main/java/org/apache/camel/model/DataFormatDefinition.java @@ -30,7 +30,6 @@ import org.apache.camel.spi.Metadata; @Metadata(label = "dataformat,transformation") @XmlType(name = "dataFormat") @XmlAccessorType(XmlAccessType.FIELD) -@SuppressWarnings("rawtypes") public class DataFormatDefinition extends IdentifiedType { @XmlTransient diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinitionHelper.java b/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinitionHelper.java index 973ed26d53b..22c440c4506 100644 --- a/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinitionHelper.java +++ b/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinitionHelper.java @@ -49,7 +49,7 @@ import static org.apache.camel.model.ProcessorDefinitionHelper.filterTypeInOutpu * Utility methods to help preparing {@link RouteDefinition} before they are added to * {@link org.apache.camel.CamelContext}. */ -@SuppressWarnings({ "unchecked", "rawtypes", "deprecation" }) +@SuppressWarnings({ "unchecked", "rawtypes" }) public final class RouteDefinitionHelper { private RouteDefinitionHelper() { diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/app/BeanConstructorsAdapter.java b/core/camel-core-model/src/main/java/org/apache/camel/model/app/BeanConstructorsAdapter.java index 4e09122732b..4cd5cfaa520 100644 --- a/core/camel-core-model/src/main/java/org/apache/camel/model/app/BeanConstructorsAdapter.java +++ b/core/camel-core-model/src/main/java/org/apache/camel/model/app/BeanConstructorsAdapter.java @@ -44,7 +44,6 @@ public class BeanConstructorsAdapter extends XmlAdapter<BeanConstructorsDefiniti } @Override - @SuppressWarnings("unchecked") public BeanConstructorsDefinition marshal(Map<Integer, Object> v) { if (v == null) { return null; diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/config/ResequencerConfig.java b/core/camel-core-model/src/main/java/org/apache/camel/model/config/ResequencerConfig.java index f54db0d728a..3ddbca2b44c 100644 --- a/core/camel-core-model/src/main/java/org/apache/camel/model/config/ResequencerConfig.java +++ b/core/camel-core-model/src/main/java/org/apache/camel/model/config/ResequencerConfig.java @@ -22,7 +22,6 @@ import jakarta.xml.bind.annotation.XmlType; @XmlType(name = "resequencerConfig") @XmlAccessorType(XmlAccessType.FIELD) -@SuppressWarnings("rawtypes") public abstract class ResequencerConfig { } diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/rest/RestDefinition.java b/core/camel-core-model/src/main/java/org/apache/camel/model/rest/RestDefinition.java index fa549a46a8f..a716672a2ee 100644 --- a/core/camel-core-model/src/main/java/org/apache/camel/model/rest/RestDefinition.java +++ b/core/camel-core-model/src/main/java/org/apache/camel/model/rest/RestDefinition.java @@ -967,7 +967,6 @@ public class RestDefinition extends OptionalIdentifiedDefinition<RestDefinition> return answer; } - @SuppressWarnings("rawtypes") private void addRouteDefinition( CamelContext camelContext, OpenApiDefinition openApi, List<RouteDefinition> answer, String component, String producerComponent, String apiContextPath, diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/aggregate/AggregateProcessor.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/aggregate/AggregateProcessor.java index 30a9ea84112..fae1fa6a712 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/aggregate/AggregateProcessor.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/aggregate/AggregateProcessor.java @@ -1504,7 +1504,6 @@ public class AggregateProcessor extends AsyncProcessorSupport } @Override - @SuppressWarnings("unchecked") protected void doStart() throws Exception { CamelContextAware.trySetCamelContext(aggregationStrategy, camelContext); if (aggregationStrategy.canPreComplete()) { diff --git a/core/camel-core/src/test/java/org/apache/camel/builder/ExceptionBuilderTest.java b/core/camel-core/src/test/java/org/apache/camel/builder/ExceptionBuilderTest.java index 9607bf84609..bc3d694daa5 100644 --- a/core/camel-core/src/test/java/org/apache/camel/builder/ExceptionBuilderTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/builder/ExceptionBuilderTest.java @@ -149,7 +149,6 @@ public class ExceptionBuilderTest extends ContextTestSupport { @Override protected RouteBuilder createRouteBuilder() throws Exception { return new RouteBuilder() { - @SuppressWarnings("unchecked") public void configure() throws Exception { errorHandler(deadLetterChannel("mock:error").redeliveryDelay(0).maximumRedeliveries(3)); diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/onexception/OnExceptionMisconfiguredTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/onexception/OnExceptionMisconfiguredTest.java index b54864dabba..e30d15736ef 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/onexception/OnExceptionMisconfiguredTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/onexception/OnExceptionMisconfiguredTest.java @@ -78,7 +78,6 @@ public class OnExceptionMisconfiguredTest extends ContextTestSupport { public void testOnExceptionMisconfigured3() throws Exception { context.addRoutes(new RouteBuilder() { @Override - @SuppressWarnings("unchecked") public void configure() throws Exception { onException(); @@ -98,7 +97,6 @@ public class OnExceptionMisconfiguredTest extends ContextTestSupport { public void testOnExceptionMisconfigured4() throws Exception { context.addRoutes(new RouteBuilder() { @Override - @SuppressWarnings("unchecked") public void configure() throws Exception { onException().end(); @@ -118,7 +116,6 @@ public class OnExceptionMisconfiguredTest extends ContextTestSupport { public void testOnExceptionMisconfigured5() throws Exception { context.addRoutes(new RouteBuilder() { @Override - @SuppressWarnings("unchecked") public void configure() throws Exception { from("direct:start").onException().end().to("mock:result"); @@ -137,7 +134,6 @@ public class OnExceptionMisconfiguredTest extends ContextTestSupport { public void testOnExceptionNotMisconfigured() throws Exception { context.addRoutes(new RouteBuilder() { @Override - @SuppressWarnings("unchecked") public void configure() throws Exception { onException().handled(true); @@ -152,7 +148,6 @@ public class OnExceptionMisconfiguredTest extends ContextTestSupport { public void testOnExceptionNotMisconfigured2() throws Exception { context.addRoutes(new RouteBuilder() { @Override - @SuppressWarnings("unchecked") public void configure() throws Exception { onException().continued(true); diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/onexception/OnExceptionsPerRouteTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/onexception/OnExceptionsPerRouteTest.java index 3848d0ae659..43ce870689b 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/onexception/OnExceptionsPerRouteTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/onexception/OnExceptionsPerRouteTest.java @@ -47,7 +47,6 @@ public class OnExceptionsPerRouteTest extends ContextTestSupport { protected RouteBuilder createRouteBuilder() throws Exception { return new RouteBuilder() { @Override - @SuppressWarnings("unchecked") public void configure() throws Exception { from("direct:start").onException(IllegalArgumentException.class, IOException.class).handled(true) .to("mock:error").end().choice().when(body().contains("Damn")) diff --git a/core/camel-management/src/main/java/org/apache/camel/management/DefaultManagementObjectStrategy.java b/core/camel-management/src/main/java/org/apache/camel/management/DefaultManagementObjectStrategy.java index 6945ddacc43..97f7ac15153 100644 --- a/core/camel-management/src/main/java/org/apache/camel/management/DefaultManagementObjectStrategy.java +++ b/core/camel-management/src/main/java/org/apache/camel/management/DefaultManagementObjectStrategy.java @@ -223,7 +223,6 @@ public class DefaultManagementObjectStrategy implements ManagementObjectStrategy } @Override - @SuppressWarnings({ "deprecation", "unchecked" }) public Object getManagedObjectForComponent(CamelContext context, Component component, String name) { ManagedComponent mc = new ManagedComponent(name, component); mc.init(context.getManagementStrategy()); @@ -231,7 +230,6 @@ public class DefaultManagementObjectStrategy implements ManagementObjectStrategy } @Override - @SuppressWarnings({ "deprecation", "unchecked" }) public Object getManagedObjectForDataFormat(CamelContext context, DataFormat dataFormat) { ManagedDataFormat md = new ManagedDataFormat(context, dataFormat); md.init(context.getManagementStrategy()); @@ -239,7 +237,6 @@ public class DefaultManagementObjectStrategy implements ManagementObjectStrategy } @Override - @SuppressWarnings({ "deprecation", "unchecked" }) public Object getManagedObjectForEndpoint(CamelContext context, Endpoint endpoint) { // we only want to manage singleton endpoints if (!endpoint.isSingleton()) { @@ -331,7 +328,6 @@ public class DefaultManagementObjectStrategy implements ManagementObjectStrategy } @Override - @SuppressWarnings({ "deprecation", "unchecked" }) public Object getManagedObjectForProcessor( CamelContext context, Processor processor, NamedNode node, Route route) { diff --git a/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java b/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java index 3c0d30cb902..60fe181a8e3 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java @@ -794,7 +794,6 @@ public final class ObjectHelper { * @return the iterable * @see Iterable */ - @SuppressWarnings("unchecked") public static Iterable<?> createIterable( Object value, String delimiter, final boolean allowEmptyValues, final boolean pattern) { @@ -821,6 +820,7 @@ public final class ObjectHelper { return trySlowIterables(value); } + @SuppressWarnings("unchecked") private static Iterable<?> trySlowIterables(Object value) { if (value instanceof Iterator) { final Iterator<Object> iterator = (Iterator<Object>) value;
