cziesman commented on code in PR #13447:
URL: https://github.com/apache/camel/pull/13447#discussion_r1521889388
##########
components/camel-qdrant/src/test/java/org/apache/camel/component/qdrant/QdrantUpsertManualIT.java:
##########
@@ -31,7 +31,7 @@
import static io.qdrant.client.ValueFactory.value;
import static org.assertj.core.api.Assertions.assertThat;
-public class QdrantUpsertTest extends QdrantTestSupport {
+public class QdrantUpsertManualIT extends QdrantTestSupport {
Review Comment:
The Quadrant tests break the unit test build because they assume the
presence of Docker without using TestContainers. Unit tests by definition
should be self contained and not depend on external resources. I can revert the
class names but there are many tests within Camel that depend on Docker that
use the `*ManualIT.java` naming convention.
Perhaps there should be a Camel standard that (1) Docker is only used with
TestContainers, or that (2) tests that depend on Docker should be named
appropriately and run manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
