lburgazzoli commented on code in PR #5090:
URL: https://github.com/apache/camel-k/pull/5090#discussion_r1485984284
##########
pkg/trait/knative.go:
##########
@@ -454,11 +468,23 @@ func (t *knativeTrait) configureSinkBinding(e
*Environment, env *knativeapi.Came
}
err := t.withServiceDo(false, e, env, services, serviceType,
knativeapi.CamelEndpointKindSink, func(ref *corev1.ObjectReference, serviceURI
string, _ func() (*url.URL, error)) error {
-
e.ApplicationProperties["camel.k.customizer.sinkbinding.enabled"] = "true"
- e.ApplicationProperties["camel.k.customizer.sinkbinding.name"]
= ref.Name
- e.ApplicationProperties["camel.k.customizer.sinkbinding.type"]
= string(serviceType)
- e.ApplicationProperties["camel.k.customizer.sinkbinding.kind"]
= ref.Kind
-
e.ApplicationProperties["camel.k.customizer.sinkbinding.api-version"] =
ref.APIVersion
+ if e.ApplicationProperties == nil {
Review Comment:
Once [CAMEL-20400](https://issues.apache.org/jira/browse/CAMEL-20400) will
become available, it should be possible to just use properties
```
came.component.knative.sink-binding.name = …
```
it is also possible to use properties to configure the knative environment
(which is also the preferred way), like:
```
camel.component.knative.environment.resources[0].type = ...
camel.component.knative.environment.resources[0].name = ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
