Nephery opened a new pull request, #13041:
URL: https://github.com/apache/camel/pull/13041
# Description
Make providing `splunkURL` and `token` through query parameters an
officially documented feature of the Splunk HEC component.
**Background**
The current method (i.e. passing tokens via path parameters) leaks sensitive
values into the logs, since Camel itself does not expect path parameters to
contain sensitive info. This PR provides an alternative means of securely
providing credentials to this component.
**PR Change Specifics**
* Marked `token` and `splunkURL` as query parameters.
* Ensured that these properties are also validated when they're set through
query parameters.
* Prevented syntax validation of the `splunkURL` and/or `token` path
parameters when their respective query parameters are already set.
# Target
- [ ] I checked that the commit is targeting the correct branch (note that
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have
committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
