(camel) branch main updated: CAMEL-20235: consolidate commit management behavior between component and endpoint (#12452)

[orpiske]

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new 7b3cff38465 CAMEL-20235: consolidate commit management behavior 
between component and endpoint (#12452)
7b3cff38465 is described below

commit 7b3cff384656cea5adaca941b6c4601302e87cc1
Author: Otavio Rodolfo Piske <orpi...@users.noreply.github.com>
AuthorDate: Thu Dec 14 13:10:27 2023 -0300

    CAMEL-20235: consolidate commit management behavior between component and 
endpoint (#12452)
---
 .../main/java/org/apache/camel/component/kafka/KafkaComponent.java | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaComponent.java
 
b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaComponent.java
index a43b1510029..387321a78a2 100644
--- 
a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaComponent.java
+++ 
b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaComponent.java
@@ -20,8 +20,8 @@ import java.util.HashMap;
 import java.util.Map;
 
 import org.apache.camel.CamelContext;
+import org.apache.camel.RuntimeCamelException;
 import org.apache.camel.SSLContextParametersAware;
-import 
org.apache.camel.component.kafka.consumer.DefaultKafkaManualCommitFactory;
 import org.apache.camel.component.kafka.consumer.KafkaManualCommit;
 import org.apache.camel.component.kafka.consumer.KafkaManualCommitFactory;
 import org.apache.camel.spi.Metadata;
@@ -30,9 +30,12 @@ import org.apache.camel.support.HealthCheckComponent;
 import org.apache.camel.support.PropertyBindingSupport;
 import org.apache.camel.util.ObjectHelper;
 import org.apache.camel.util.PropertiesHelper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 @Component("kafka")
 public class KafkaComponent extends HealthCheckComponent implements 
SSLContextParametersAware {
+    private static final Logger LOG = 
LoggerFactory.getLogger(KafkaComponent.class);
 
     @Metadata
     private KafkaConfiguration configuration = new KafkaConfiguration();
@@ -232,7 +235,7 @@ public class KafkaComponent extends HealthCheckComponent 
implements SSLContextPa
             kafkaClientFactory = new DefaultKafkaClientFactory();
         }
         if (configuration.isAllowManualCommit() && kafkaManualCommitFactory == 
null) {
-            kafkaManualCommitFactory = new DefaultKafkaManualCommitFactory();
+            LOG.warn("The component was setup for allowing manual commits, but 
a manual commit factory was not set");
         }
     }