CodeSmell commented on code in PR #11960:
URL: https://github.com/apache/camel/pull/11960#discussion_r1388495185
##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/consumer/support/KafkaRecordProcessorFacade.java:
##########
@@ -126,7 +129,7 @@ private ProcessingResult processRecord(
ProcessingResult currentResult
= kafkaRecordProcessor.processExchange(exchange, partition,
partitionHasNext,
- recordHasNext, record, lastResult,
camelKafkaConsumer.getExceptionHandler());
+ recordHasNext, record,
camelKafkaConsumer.getExceptionHandler());
if (!currentResult.isBreakOnErrorHit()) {
commitManager.recordOffset(partition,
currentResult.getPartitionLastOffset());
Review Comment:
this part of the code is one of 2 reasons I can see that we need the offset
in `ProcessedResult`
may be worth trying to move it inside `createExchange`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
