brunoriemenschneider commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1385006037
##########
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##########
@@ -120,6 +120,8 @@ public class SmppConfiguration implements Cloneable {
private Integer pduProcessorQueueCapacity = 100;
@UriParam(label = "advanced", defaultValue = "false")
private boolean singleDLR;
+ @UriParam(label = "advanced", enums = "0x00,0x33,0x34,0x50", defaultValue
= "0x34")
+ private String interfaceVersion = "0x34";
Review Comment:
The SMPP protocol uses these codes (e.g. se https://smpp.org/SMPP_v5.pdf -
chapter 4.7.13) in its specification. Are you sure I should remove them? (Code
is simpler/easier to understand like this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
