squakez commented on code in PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#discussion_r1381602953
##########
script/Makefile:
##########
@@ -430,7 +430,7 @@ check-licenses:
maven-overlay:
@echo "####### Preparing maven dependencies bundle..."
mkdir -p build/_maven_overlay
- ./script/maven_overlay.sh -s "$(STAGING_RUNTIME_REPO)" -d
"$(CAMEL_K_RUNTIME_DIR)" $(DEFAULT_RUNTIME_VERSION) build/_maven_overlay
+ ./script/maven_overlay.sh build/_maven_overlay
Review Comment:
Ah, I overlooked it. Nitpick: maybe it is better to use `package` phase
instead of `install`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
