This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new b76c9c569b2 (chores) camel-core: use final where possible
b76c9c569b2 is described below
commit b76c9c569b2134ca73a70937adbe6b1f3743f105
Author: Otavio R. Piske <[email protected]>
AuthorDate: Sat Sep 23 17:31:36 2023 +0200
(chores) camel-core: use final where possible
Signed-off-by: Otavio R. Piske <[email protected]>
---
.../apache/camel/impl/converter/AnnotationTypeConverterLoader.java | 6 +++---
.../src/main/java/org/apache/camel/impl/DefaultModel.java | 2 +-
.../camel/management/mbean/ManagedExchangeFactoryManager.java | 2 +-
.../src/main/java/org/apache/camel/support/jndi/JndiContext.java | 2 +-
.../main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java | 6 +++---
.../src/main/java/org/apache/camel/xml/in/BaseParser.java | 2 +-
.../src/main/java/org/apache/camel/converter/jaxp/XmlConverter.java | 2 +-
7 files changed, 11 insertions(+), 11 deletions(-)
diff --git
a/core/camel-base/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java
b/core/camel-base/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java
index faabeb5225d..3f9cc8ecb83 100644
---
a/core/camel-base/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java
+++
b/core/camel-base/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java
@@ -67,9 +67,9 @@ public class AnnotationTypeConverterLoader implements
TypeConverterLoader {
public static final String META_INF_SERVICES =
"META-INF/services/org/apache/camel/TypeConverter";
private static final Logger LOG =
LoggerFactory.getLogger(AnnotationTypeConverterLoader.class);
private static final Charset UTF8 = StandardCharsets.UTF_8;
- protected PackageScanClassResolver resolver;
- protected Set<Class<?>> visitedClasses = new HashSet<>();
- protected Set<String> visitedURIs = new HashSet<>();
+ protected final PackageScanClassResolver resolver;
+ protected final Set<Class<?>> visitedClasses = new HashSet<>();
+ protected final Set<String> visitedURIs = new HashSet<>();
private final String basePackage;
public AnnotationTypeConverterLoader(PackageScanClassResolver resolver) {
diff --git
a/core/camel-core-engine/src/main/java/org/apache/camel/impl/DefaultModel.java
b/core/camel-core-engine/src/main/java/org/apache/camel/impl/DefaultModel.java
index 1f651f3fc24..657db043fed 100644
---
a/core/camel-core-engine/src/main/java/org/apache/camel/impl/DefaultModel.java
+++
b/core/camel-core-engine/src/main/java/org/apache/camel/impl/DefaultModel.java
@@ -93,7 +93,7 @@ public class DefaultModel implements Model {
private List<TransformerDefinition> transformers = new ArrayList<>();
private List<ValidatorDefinition> validators = new ArrayList<>();
// XML and YAML DSL allows to declare beans in the DSL
- private List<RegistryBeanDefinition> beans = new ArrayList<>();
+ private final List<RegistryBeanDefinition> beans = new ArrayList<>();
private final Map<String, ServiceCallConfigurationDefinition>
serviceCallConfigurations = new ConcurrentHashMap<>();
private final Map<String, Resilience4jConfigurationDefinition>
resilience4jConfigurations = new ConcurrentHashMap<>();
private final Map<String, FaultToleranceConfigurationDefinition>
faultToleranceConfigurations = new ConcurrentHashMap<>();
diff --git
a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedExchangeFactoryManager.java
b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedExchangeFactoryManager.java
index f5c67135b04..8eec7900d25 100644
---
a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedExchangeFactoryManager.java
+++
b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedExchangeFactoryManager.java
@@ -37,7 +37,7 @@ import org.apache.camel.util.URISupport;
@ManagedResource(description = "Managed ExchangeFactory")
public class ManagedExchangeFactoryManager extends ManagedService implements
ManagedExchangeFactoryManagerMBean {
- private ExchangeFactoryManager exchangeFactoryManager;
+ private final ExchangeFactoryManager exchangeFactoryManager;
private boolean sanitize;
public ManagedExchangeFactoryManager(CamelContext context,
ExchangeFactoryManager exchangeFactoryManager) {
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/jndi/JndiContext.java
b/core/camel-support/src/main/java/org/apache/camel/support/jndi/JndiContext.java
index 1bcfb964945..9f1f4e2ce55 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/jndi/JndiContext.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/jndi/JndiContext.java
@@ -381,7 +381,7 @@ public class JndiContext implements Context, Serializable {
}
private abstract class LocalNamingEnumeration implements
NamingEnumeration<Object> {
- private Iterator<Map.Entry<String, Object>> i =
bindings.entrySet().iterator();
+ private final Iterator<Map.Entry<String, Object>> i =
bindings.entrySet().iterator();
@Override
public boolean hasMore() throws NamingException {
diff --git
a/core/camel-util/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
b/core/camel-util/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
index 65f0cc5a12b..023235ef169 100644
---
a/core/camel-util/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
+++
b/core/camel-util/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
@@ -25,9 +25,9 @@ import java.util.List;
* A good source for details is <a
href="http://en.wikipedia.org/wiki/Url_encode";>wikipedia url encode</a> article.
*/
public final class UnsafeUriCharactersEncoder {
- private static BitSet unsafeCharactersFastParser;
- private static BitSet unsafeCharactersRfc1738;
- private static BitSet unsafeCharactersHttp;
+ private static final BitSet unsafeCharactersFastParser;
+ private static final BitSet unsafeCharactersRfc1738;
+ private static final BitSet unsafeCharactersHttp;
private static final char[] HEX_DIGITS = {
'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C',
'D', 'E', 'F', 'a', 'b', 'c', 'd', 'e', 'f' };
diff --git
a/core/camel-xml-io/src/main/java/org/apache/camel/xml/in/BaseParser.java
b/core/camel-xml-io/src/main/java/org/apache/camel/xml/in/BaseParser.java
index f53b7f5c6ce..a68737baf23 100644
--- a/core/camel-xml-io/src/main/java/org/apache/camel/xml/in/BaseParser.java
+++ b/core/camel-xml-io/src/main/java/org/apache/camel/xml/in/BaseParser.java
@@ -54,7 +54,7 @@ public class BaseParser {
protected final MXParser parser;
protected String namespace;
- protected Set<String> secondaryNamespaces = new HashSet<>();
+ protected final Set<String> secondaryNamespaces = new HashSet<>();
protected Resource resource;
public BaseParser(Resource resource) throws IOException,
XmlPullParserException {
diff --git
a/core/camel-xml-jaxp/src/main/java/org/apache/camel/converter/jaxp/XmlConverter.java
b/core/camel-xml-jaxp/src/main/java/org/apache/camel/converter/jaxp/XmlConverter.java
index f45a846f4f4..d91a9cc4e14 100644
---
a/core/camel-xml-jaxp/src/main/java/org/apache/camel/converter/jaxp/XmlConverter.java
+++
b/core/camel-xml-jaxp/src/main/java/org/apache/camel/converter/jaxp/XmlConverter.java
@@ -90,7 +90,7 @@ public class XmlConverter {
public static final String OUTPUT_PROPERTIES_PREFIX =
"org.apache.camel.xmlconverter.output.";
public static final String DOCUMENT_BUILDER_FACTORY_FEATURE
= "org.apache.camel.xmlconverter.documentBuilderFactory.feature";
- public static String defaultCharset =
ObjectHelper.getSystemProperty(Exchange.DEFAULT_CHARSET_PROPERTY, "UTF-8");
+ public static final String defaultCharset =
ObjectHelper.getSystemProperty(Exchange.DEFAULT_CHARSET_PROPERTY, "UTF-8");
private static final String JDK_FALLBACK_TRANSFORMER_FACTORY
=
"com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl";
