[camel] branch main updated: (chores) camel-test-junit5: code cleanups: (#11024)

[orpiske]

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new 9960826227a (chores) camel-test-junit5: code cleanups: (#11024)
9960826227a is described below

commit 9960826227add52af8fb8403592c050169898e9b
Author: Otavio Rodolfo Piske <orpi...@users.noreply.github.com>
AuthorDate: Mon Aug 7 16:05:24 2023 +0200

    (chores) camel-test-junit5: code cleanups: (#11024)
    
    - simplified assertion
    - simplify other complex operations
---
 .../main/java/org/apache/camel/test/CamelRouteCoverageDumper.java    | 2 +-
 .../org/apache/camel/test/junit5/params/ParameterizedExtension.java  | 5 ++---
 .../org/apache/camel/test/junit5/patterns/AsyncSendMockTest.java     | 5 +++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git 
a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/CamelRouteCoverageDumper.java
 
b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/CamelRouteCoverageDumper.java
index 9849935cd83..ad534686597 100644
--- 
a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/CamelRouteCoverageDumper.java
+++ 
b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/CamelRouteCoverageDumper.java
@@ -191,7 +191,7 @@ public class CamelRouteCoverageDumper {
                 .append(contextExchangesTotal).append("\n");
 
         if (!uncoveredRoutes.isEmpty()) {
-            builder.append("\t\tUncovered routes: 
").append(uncoveredRoutes.stream().collect(Collectors.joining(", ")))
+            builder.append("\t\tUncovered routes: ").append(String.join(", ", 
uncoveredRoutes))
                     .append("\n");
         }
 
diff --git 
a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/params/ParameterizedExtension.java
 
b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/params/ParameterizedExtension.java
index ac61a0ed9df..cda04cfc491 100644
--- 
a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/params/ParameterizedExtension.java
+++ 
b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/params/ParameterizedExtension.java
@@ -19,7 +19,6 @@ package org.apache.camel.test.junit5.params;
 import java.lang.reflect.Field;
 import java.lang.reflect.Method;
 import java.lang.reflect.Modifier;
-import java.util.Arrays;
 import java.util.Comparator;
 import java.util.List;
 import java.util.stream.Collectors;
@@ -116,7 +115,7 @@ public class ParameterizedExtension implements 
TestTemplateInvocationContextProv
 
         @Override
         public java.util.List<Extension> getAdditionalExtensions() {
-            return Arrays.asList(
+            return List.of(
                     (TestInstancePostProcessor) this::postProcessTestInstance);
         }
 
@@ -127,7 +126,7 @@ public class ParameterizedExtension implements 
TestTemplateInvocationContextProv
                     .flatMap(Stream::of)
                     .filter(f -> isAnnotated(f, Parameter.class))
                     .sorted(Comparator.comparing(f -> (Integer) 
f.getAnnotation(Parameter.class).value()))
-                    .collect(Collectors.toList());
+                    .toList();
             if (params.length != fields.size()) {
                 throw new TestInstantiationException(
                         "Expected " + fields.size() + " parameters bug got " + 
params.length + " when instantiating "
diff --git 
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/AsyncSendMockTest.java
 
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/AsyncSendMockTest.java
index 10b0b91aaae..c2ee57c0a01 100644
--- 
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/AsyncSendMockTest.java
+++ 
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/AsyncSendMockTest.java
@@ -24,6 +24,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
 
 public class AsyncSendMockTest extends CamelTestSupport {
     private static final Logger LOG = 
LoggerFactory.getLogger(AsyncSendMockTest.class);
@@ -34,7 +35,7 @@ public class AsyncSendMockTest extends CamelTestSupport {
     }
 
     @Test
-    public void testmakeAsyncApiCall() {
+    public void testMakeAsyncApiCall() {
         try {
             
getMockEndpoint("mock:seda:start").expectedHeaderReceived("username", 
"admin123");
             getMockEndpoint("mock:seda:start").expectedBodiesReceived("Hello");
@@ -46,7 +47,7 @@ public class AsyncSendMockTest extends CamelTestSupport {
             MockEndpoint.assertIsSatisfied(context);
         } catch (Exception e) {
             LOG.warn("Failed to make async call to api: {}", e.getMessage(), 
e);
-            assertTrue(false, "Failed to make async call to api");
+            fail("Failed to make async call to api");
         }
     }
 }