jamesnetherton commented on code in PR #4677:
URL: https://github.com/apache/camel-quarkus/pull/4677#discussion_r1142962991
##########
extensions/jackson/deployment/pom.xml:
##########
@@ -45,6 +45,10 @@
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-jackson</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.datatype</groupId>
+ <artifactId>jackson-datatype-joda</artifactId>
+ </dependency>
Review Comment:
We probably should not be adding `jackson-datatype-joda` as a dependency to
`camel-quarkus-jackson` at all. Instead, we could have some logic to detect if
its on the classpath (with `QuarkusClassLoader.isClassPresentAtRuntime`) and
register `JodaModule` for reflection if it is.
Or if we must add it, add it as scope 'provided'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
