tadayosi commented on code in PR #3788:
URL: https://github.com/apache/camel-k/pull/3788#discussion_r1010081175
##########
pkg/trait/trait_test.go:
##########
@@ -457,7 +457,7 @@ func TestConfigureVolumesAndMountsBinaryAndTextResources(t
*testing.T) {
func TestOnlySomeTraitsInfluenceBuild(t *testing.T) {
c := NewTraitTestCatalog()
- buildTraits := []string{"builder", "quarkus", "registry"}
+ buildTraits := []string{"builder", "quarkus", "registry", "camel"}
Review Comment:
Same here.
##########
pkg/apis/camel/v1/integrationkit_types.go:
##########
@@ -77,7 +77,8 @@ type IntegrationKitTraits struct {
Quarkus *trait.QuarkusTrait `property:"quarkus"
json:"quarkus,omitempty"`
// The Registry trait sets up Maven to use the Image registry as a
Maven repository.
Registry *trait.RegistryTrait `property:"registry"
json:"registry,omitempty"`
-
+ // The Camel trait sets up Camel configuration.
+ Camel *trait.CamelTrait `property:"camel" json:"camel,omitempty"`
Review Comment:
Nitpick: It'd be better to keep alphabetical order, which means Camel should
be put between Builder and Quarkus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
