squakez commented on code in PR #3309:
URL: https://github.com/apache/camel-k/pull/3309#discussion_r885328491
##########
pkg/trait/builder.go:
##########
@@ -101,7 +102,14 @@ func (t *builderTrait) Apply(e *Environment) error {
}})
case v1.IntegrationPlatformBuildPublishStrategyBuildah:
+ var platform string
+ var found bool
+ if platform, found =
e.Platform.Status.Build.PublishStrategyOptions[builder.BuildahPlatform]; !found
{
+ platform = platforms.DefaultSpec().OS + "/" +
platforms.DefaultSpec().Architecture + "/" + platforms.DefaultSpec().Variant
Review Comment:
My main concern is we introduce a dependency (with all its maintenance
burden) just to get some OS info. Could we try instead using something already
available in the Go language (ie, https://pkg.go.dev/runtime#GOOS).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
