sbalmer commented on PR #7376: URL: https://github.com/apache/camel/pull/7376#issuecomment-1090120931
Unresolved issues: * I just used the name from the underlying library. But I'm not too happy with the `exitValues` name. Something like `expectedExitValues`, `acceptedExitValues` or just `failOnNonzeroExitValue` would be other possibilities. * There is no functional test because I couldn't get `ExecScriptTest` to work on my installation. It complained about a missing JAVA_HOME which is set. I'm unclear on how to proceed. I hacked `ExecJava8IssueTest` to test whether it fails with `exitValues=1` locally, and that worked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
