squakez commented on a change in pull request #3123:
URL: https://github.com/apache/camel-k/pull/3123#discussion_r828155893
##########
File path: script/get_catalog.sh
##########
@@ -21,14 +21,12 @@ rootdir=$location/../
if [ "$#" -ge 1 ]; then
runtimeVersion="$1"
shift 1
- $rootdir/mvnw -q \
- -f ${rootdir}/build/maven/pom-catalog.xml \
- -Dcatalog.path=${rootdir}/resources \
- -Druntime.version=$runtimeVersion \
- -B \
- -U \
- "$@"
+ # the catalog was already provided by Camel K runtime. No need to depends on
maven to rebuild it
+ wget -q
https://repo1.maven.org/maven2/org/apache/camel/k/camel-k-catalog/$runtimeVersion/camel-k-catalog-$runtimeVersion-catalog.yaml
-O ${rootdir}/resources/camel-catalog-$runtimeVersion.yaml
+ # TODO if we need to use also staging, then we must parse the maven-metadata
from the staging repository
Review comment:
@oscerd I'd like your opinion here. When we're using stable version, we
should be fine picking up the catalog built. Is there any interim situation
where we're using `SNAPSHOT` (ie, during release process)? if so, I can work to
include it as described in the TODO comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
