jamesnetherton commented on a change in pull request #7022:
URL: https://github.com/apache/camel/pull/7022#discussion_r812815115
##########
File path:
components/camel-vertx/camel-vertx-websocket/src/test/java/org/apache/camel/component/vertx/websocket/VertxWebsocketTest.java
##########
@@ -163,6 +163,9 @@ public void testSendWithMultipleConnectionKeys() throws
Exception {
@Test
public void testSendToAll() throws Exception {
+ MockEndpoint mockEndpoint = getMockEndpoint("mock:result");
+ mockEndpoint.expectedMessageCount(0);
Review comment:
I
[compared](https://gist.githubusercontent.com/jamesnetherton/9b0849e48330e184491e281da8c64ac4/raw/6084befd2091dae8e41c6b9b4510e9f1cfffa9cd/SendToAllTest.java)
with how `camel-undertow` does things. With `sendToAll` and it only sends the
message to the connected peers and the consumer route does not run. So this
change would make `vertx-websocket` in line with that behavior.
Still not sure if that's totally correct though. If I do
`.to("vertx-websocket:localhost:8080/foo?sendToAll=true")`, then to me it means
that I want to send a message to the thing listening on `localhost:8080` and
any connected peers.
But maybe we merge this change as-is given that it fixes a specific problem
and try to enhance things further in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
