VratislavHais commented on a change in pull request #3170:
URL: https://github.com/apache/camel-quarkus/pull/3170#discussion_r724918363
##########
File path:
integration-test-groups/aws2/aws2-sqs-sns/src/test/java/org/apache/camel/quarkus/component/aws2/sqs/it/Aws2SqsSnsTest.java
##########
@@ -65,10 +96,12 @@ public void sqs() {
@Test
public void sqsDeleteMessage() {
final String qName = getPredefinedQueueName();
- final String msg = sendSingleMessageToQueue(qName);
+ sendSingleMessageToQueue(qName);
final String receipt = receiveReceiptOfMessageFromQueue(qName);
+ final String msg = sendSingleMessageToQueue(qName);
deleteMessageFromQueue(qName, receipt);
- Assertions.assertNotEquals(receiveMessageFromQueue(qName), msg);
+ awaitMessageWithExpectedContentFromQueue(msg, qName);
Review comment:
We send there two messages, so the queue looks like this:
msg2 -> msg1 ->
afterwards we delete the first added msg (msg1). This is our queue:
msg2 ->
now we request message from queue and we should get msg2. We do not delete
the message so the second request should again return msg2.
Now if delete didn't work as expected it could either delete msg2
accidentally (covered) or delete no message at all. To check the second option
it's better (in my opinion) to request two messages. One of them would violate
our check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
