ppalaga commented on a change in pull request #2986:
URL: https://github.com/apache/camel-quarkus/pull/2986#discussion_r682926665
##########
File path: pom.xml
##########
@@ -585,7 +585,7 @@
<executions>
<execution>
<id>default-test</id>
- <phase /><!-- unbound here to speedup -Dquickly build;
bound to a phase in camel-quarkus-build-parent-it -->
Review comment:
I think we should finally agree whether we want a space here or not :)
cq plugin mojos are currently set up to remove the spaces, but someone's IDE
puts them back (isn't that you @jamesnetherton?) I can change the cq plugin to
add the spaces if there's an agreement that it is prettier.
##########
File path: pom.xml
##########
@@ -585,7 +585,7 @@
<executions>
<execution>
<id>default-test</id>
- <phase /><!-- unbound here to speedup -Dquickly build;
bound to a phase in camel-quarkus-build-parent-it -->
Review comment:
Ups, sorry for accusing you! Yeah, the spaces are added by `mvn
release:update-versions`. Let me have a look what we can do.
##########
File path: pom.xml
##########
@@ -585,7 +585,7 @@
<executions>
<execution>
<id>default-test</id>
- <phase /><!-- unbound here to speedup -Dquickly build;
bound to a phase in camel-quarkus-build-parent-it -->
Review comment:
jdom2 used by the release plugin internally is very opinionated about
this:
https://github.com/hunterhacker/jdom/blob/master/core/src/java/org/jdom2/output/support/AbstractXMLOutputProcessor.java#L824
So I better adapt the cq plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
