ppalaga commented on a change in pull request #2786:
URL: https://github.com/apache/camel-quarkus/pull/2786#discussion_r652104042
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the
following option. The kamelet to pre-load can be listed using the
`quarkus.camel.kamelet.identifiers` property.
Review comment:
```suggestion
This extension allows to pre-load a set of Kamelets at build time using the
`quarkus.camel.kamelet.identifiers` property.
```
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the
following option. The kamelet to pre-load can be listed using the
`quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the
https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your
project in the classpath location defined by the
`quarkus.camel.kamelet.location` property, or you can add the
`camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
Review comment:
> you either need to copy them
What is "them"? What kind of files are the end users supposed to copy from
where?
##########
File path:
extensions/kamelet/runtime/src/main/java/org/apache/camel/quarkus/component/kamelet/KameletConfiguration.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.kamelet;
+
+import java.util.List;
+import java.util.Optional;
+
+import io.quarkus.runtime.annotations.ConfigItem;
+import io.quarkus.runtime.annotations.ConfigPhase;
+import io.quarkus.runtime.annotations.ConfigRoot;
+
+@ConfigRoot(name = "camel.kamelet", phase = ConfigPhase.BUILD_TIME)
+public class KameletConfiguration {
+ /**
+ * List of kamelets identifiers to pre-load at build time.
+ *
+ * <p/>
Review comment:
```suggestion
* <p>
```
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the
following option. The kamelet to pre-load can be listed using the
`quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the
https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your
project in the classpath location defined by the
`quarkus.camel.kamelet.location` property, or you can add the
`camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
+
+[source,xml]
+----
+<dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-kamelets-catalog</artifactId>
+</dependency>
+----
+
+This artifact makes all the kamelets available in the catalog available to
Camel Quarkus for build time processing, the artefact is not part of the
runtime classpath.
Review comment:
```suggestion
This artifact makes all the kamelets available in the catalog available to
Camel Quarkus for build time processing, the artifact is not part of the
runtime classpath.
```
> the artifact is not part of the runtime classpath.
How is that meant? It is there as a dependency of the user app, but it is
not there at runtime of the user app? Could you please add a sentence
explaining how is that possible?
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the
following option. The kamelet to pre-load can be listed using the
`quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
Review comment:
What does not exist? If there is something left to do, please file a
follow up issue and paste the link here.
##########
File path: extensions/kamelet/runtime/src/main/doc/usage.adoc
##########
@@ -0,0 +1,20 @@
+=== Pre-load Kamelets at build-time
+
+This extension allow to pre-load a set of Kamelets at build time through the
following option. The kamelet to pre-load can be listed using the
`quarkus.camel.kamelet.identifiers` property.
+
+=== Using the Kamelet Catalog
+
+//TODO: does not yet exist
+
+A set of pre-made Kamelets can be found on the
https://camel.apache.org/camel-kamelets/latest[Kamelet Catalog].
+To use the Kamelet from the catalog you either need to copy them on your
project in the classpath location defined by the
`quarkus.camel.kamelet.location` property, or you can add the
`camel-quarkus-kamelets-catalog` artifact to your `pom.xml`:
Review comment:
I do not see `quarkus.camel.kamelet.location` anywhere in the code. Am I
overseeing it or that's the missing part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
