orpiske commented on a change in pull request #2311:
URL: https://github.com/apache/camel-k/pull/2311#discussion_r634998907
##########
File path: pkg/util/maven/maven.go
##########
@@ -178,17 +178,24 @@ func Run(ctx Context) error {
Log.Debug("About to start parsing the Maven output")
+ structuredLogs := HasStructuredLog()
+
for scanner.Scan() {
Review comment:
Thanks @astefanutti ! I think you are right.
One thing that I did not consider - even in the original implementation -
is: what if we have an output to the maven log that outputs non-structured
bits? In this case, it should go to the normal logger instead of the
normalization part.
And, in fact, there are a few scenarios where this could happen (i.e.: for
example, if the JDK prints a warning, a misbehaved maven plugin bypass the
Maven logger, etc).
Let me re-adjust the implementation based on your feedback before we merge
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
