astefanutti commented on a change in pull request #2114:
URL: https://github.com/apache/camel-k/pull/2114#discussion_r593185058
##########
File path: pkg/util/kubernetes/util.go
##########
@@ -228,3 +232,37 @@ func ResolveValueSource(ctx context.Context, client
k8sclient.Reader, namespace
return "", nil
}
+
+// GetTolerations build an array of Tolerations from an array of string
+func GetTolerations(taints []string) ([]corev1.Toleration, error) {
Review comment:
What I could propose is:
- Move all the _client_ methods, that use `context context.Context, client
k8sclient.Reader`, in a `client.go` or `reader.go` file
- Move the `GetTolerations` into either a `factory.go` file, if we plan to
add more factory methods or group the existing ones, or a `toleration.go` file,
if we want to be more granular.
I understand this is opinion when it comes to naming and grouping, so I'll
trust and respect your choice :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
