johnpoth commented on a change in pull request #1952:
URL: https://github.com/apache/camel-k/pull/1952#discussion_r566850214
##########
File path: pkg/controller/integration/platform_setup.go
##########
@@ -46,7 +46,8 @@ func (action *platformSetupAction) Name() string {
// CanHandle tells whether this action can handle the integration
func (action *platformSetupAction) CanHandle(integration *v1.Integration) bool
{
return integration.Status.Phase == v1.IntegrationPhaseNone ||
- integration.Status.Phase ==
v1.IntegrationPhaseWaitingForPlatform
+ integration.Status.Phase ==
v1.IntegrationPhaseWaitingForPlatform ||
+ integration.Status.Phase ==
v1.IntegrationPhaseWaitingForServiceBindingCollectionReady
Review comment:
I added the IntegrationPhaseWaitingForServiceBindingCollectionReady
phase to the platform_setup action but I could create a new one and add it
there? It was convenient because it's the first one called and setting up the
servicebinding should be done as early as possible. Also this Action does not
modify the IntegrationPhase which allowed me to set it in the trait.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
