This is an automated email from the ASF dual-hosted git repository.
pinal pushed a commit to branch ATLAS-5021
in repository https://gitbox.apache.org/repos/asf/atlas.git
The following commit(s) were added to refs/heads/ATLAS-5021 by this push:
new 9c2d81fce address copilot review comment
9c2d81fce is described below
commit 9c2d81fce97bacae02c2c8ee4d466adbbfa6a35a
Author: Pinal Shah <[email protected]>
AuthorDate: Thu Aug 14 22:58:48 2025 +0530
address copilot review comment
---
addons/models/6000-Trino/6000-trino_model.json | 720 +++++++++------------
.../apache/atlas/trino/cli/ExtractorService.java | 2 +-
.../atlas/trino/client/AtlasClientHelper.java | 24 +-
.../atlas/trino/connector/ConnectorFactory.java | 2 +-
.../atlas/trino/connector/HiveEntityConnector.java | 2 +-
.../trino/connector/IcebergEntityConnector.java | 2 +-
.../apache/atlas/trino/cli/TrinoExtractorIT.java | 2 +-
7 files changed, 310 insertions(+), 444 deletions(-)
diff --git a/addons/models/6000-Trino/6000-trino_model.json
b/addons/models/6000-Trino/6000-trino_model.json
index 1ab71c42d..6d70fa8f4 100644
--- a/addons/models/6000-Trino/6000-trino_model.json
+++ b/addons/models/6000-Trino/6000-trino_model.json
@@ -1,454 +1,320 @@
{
- "enumDefs": [],
- "structDefs": [],
- "classificationDefs": [],
- "entityDefs": [
- {
- "name": "trino_instance",
- "superTypes": ["DataSet"],
- "serviceType": "trino",
- "typeVersion": "1.0",
- "attributeDefs": [
- {
- "name": "hostname",
- "typeName": "string",
- "isOptional": true,
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false
- },
- {
- "name": "port",
- "typeName": "int",
- "isOptional": true,
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false
- }
- ]
- },
+ "enumDefs": [],
+ "structDefs": [],
+ "classificationDefs": [],
+ "entityDefs": [
+ {
+ "name": "trino_instance",
+ "superTypes": [ "DataSet" ],
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "attributeDefs": [
{
- "name": "trino_catalog",
- "superTypes": [
- "Asset"
- ],
- "serviceType": "trino",
- "typeVersion": "1.0",
- "attributeDefs": [
- {
- "name": "connectorType",
- "typeName": "string",
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false
- },
- {
- "name": "connectionUrl",
- "typeName": "string",
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false,
- "isOptional": true
- },
- {
- "name": "endPointUrl",
- "typeName": "string",
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false,
- "isOptional": true
- },{
- "name": "extraConfigs",
- "typeName": "map<string,string>",
- "cardinality": "SINGLE",
- "isIndexable": false,
- "isOptional": true,
- "isUnique": false
- }
- ]
+ "name": "hostname",
+ "typeName": "string",
+ "isOptional": true,
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false
},
{
- "name": "trino_schema",
- "superTypes": [
- "Asset"
- ],
- "serviceType": "trino",
- "typeVersion": "1.0",
- "attributeDefs": [
- {
- "name": "parameters",
- "typeName": "map<string,string>",
- "cardinality": "SINGLE",
- "isIndexable": false,
- "isOptional": true,
- "isUnique": false
- }
- ]
- },
+ "name": "port",
+ "typeName": "int",
+ "isOptional": true,
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false
+ }
+ ]
+ },
+ {
+ "name": "trino_catalog",
+ "superTypes": [ "Asset" ],
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "attributeDefs": [
{
- "name": "trino_table",
- "superTypes": [
- "DataSet"
- ],
- "serviceType": "trino",
- "typeVersion": "1.0",
- "attributeDefs": [
- {
- "name": "comment",
- "typeName": "string",
- "cardinality": "SINGLE",
- "isIndexable": false,
- "isOptional": true,
- "isUnique": false
- },
- {
- "name": "parameters",
- "typeName": "map<string,string>",
- "cardinality": "SINGLE",
- "isIndexable": false,
- "isOptional": true,
- "isUnique": false
- },
- {
- "name": "table_type",
- "typeName": "string",
- "cardinality": "SINGLE",
- "isIndexable": false,
- "isOptional": true,
- "isUnique": false
- }
- ]
+ "name": "connectorType",
+ "typeName": "string",
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false
},
{
- "name": "trino_column",
- "superTypes": [
- "DataSet"
- ],
- "serviceType": "trino",
- "typeVersion": "1.0",
- "attributeDefs": [
- {
- "name": "data_type",
- "typeName": "string",
- "isOptional": true,
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": true
- },
- {
- "name": "ordinal_position",
- "typeName": "int",
- "isOptional": true,
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false
- },
- {
- "name": "column_default",
- "typeName": "string",
- "isOptional": true,
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false
- },
- {
- "name": "comment",
- "typeName": "string",
- "isOptional": true,
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false
- },
- {
- "name": "is_nullable",
- "typeName": "boolean",
- "isOptional": true,
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false
- },
- {
- "name": "isPrimaryKey",
- "typeName": "boolean",
- "isOptional": true,
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false
- }
-
- ]
- },
- {
- "name" : "trino_column_lineage",
- "superTypes" : [
- "Process"
- ],
- "serviceType": "trino",
- "typeVersion" : "1.0",
- "attributeDefs" : [
- {
- "name": "expression",
- "typeName": "string",
- "cardinality" : "SINGLE",
- "isIndexable": false,
- "isOptional": true,
- "isUnique": false
- }
- ]
- },
+ "name": "connectionUrl",
+ "typeName": "string",
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false,
+ "isOptional": true
+ }
+ ]
+ },
+ {
+ "name": "trino_schema",
+ "superTypes": [ "Asset" ],
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "attributeDefs": [
+ {
+ "name": "parameters",
+ "typeName": "map<string,string>",
+ "cardinality": "SINGLE",
+ "isIndexable": false,
+ "isOptional": true,
+ "isUnique": false
+ }
+ ]
+ },
+ {
+ "name": "trino_table",
+ "superTypes": [ "DataSet" ],
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "attributeDefs": [
{
- "name": "trino_process",
- "superTypes": [
- "Process"
- ],
- "serviceType": "trino",
- "typeVersion": "1.0",
- "attributeDefs": [
- {
- "name": "queryId",
- "typeName": "string",
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false,
- "searchWeight": 5
- },
- {
- "name": "queryCreateTime",
- "typeName": "long",
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false,
- "searchWeight": 5
- },
- {
- "name": "queryEndTime",
- "typeName": "long",
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false,
- "searchWeight": 5
- },
- {
- "name": "queryText",
- "typeName": "string",
- "cardinality": "SINGLE",
- "isUnique": false,
- "isIndexable": false,
- "searchWeight": 5
- }
- ]
+ "name": "comment",
+ "typeName": "string",
+ "cardinality": "SINGLE",
+ "isIndexable": false,
+ "isOptional": true,
+ "isUnique": false
},
{
- "name": "trino_schema_ddl",
- "superTypes": [
- "ddl"
- ],
- "serviceType": "trino",
- "typeVersion": "1.0",
- "attributeDefs": []
+ "name": "parameters",
+ "typeName": "map<string,string>",
+ "cardinality": "SINGLE",
+ "isIndexable": false,
+ "isOptional": true,
+ "isUnique": false
},
{
- "name": "trino_table_ddl",
- "superTypes": [
- "ddl"
- ],
- "serviceType": "trino",
- "typeVersion": "1.0",
- "attributeDefs": []
+ "name": "table_type",
+ "typeName": "string",
+ "cardinality": "SINGLE",
+ "isIndexable": false,
+ "isOptional": true,
+ "isUnique": false
}
- ],
- "relationshipDefs": [
- {
- "name": "trino_instance_catalog",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "COMPOSITION",
- "endDef1": {
- "type": "trino_catalog",
- "name": "instance",
- "isContainer": false,
- "cardinality": "SINGLE",
- "isLegacyAttribute": false
- },
- "endDef2": {
- "type": "trino_instance",
- "name": "catalogs",
- "isContainer": true,
- "cardinality": "SET"
- },
- "propagateTags": "NONE"
- },
-
- {
- "name": "trino_schema_catalog",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "AGGREGATION",
- "endDef1": {
- "type": "trino_schema",
- "name": "catalog",
- "isContainer": false,
- "cardinality": "SINGLE",
- "isLegacyAttribute": false
- },
- "endDef2": {
- "type": "trino_catalog",
- "name": "schemas",
- "isContainer": true,
- "cardinality": "SET"
- },
- "propagateTags": "NONE"
+ ]
+ },
+ {
+ "name": "trino_column",
+ "superTypes": [ "DataSet" ],
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "attributeDefs": [
+ {
+ "name": "data_type",
+ "typeName": "string",
+ "isOptional": true,
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": true
},
-
- {
- "name": "trino_table_schema",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "AGGREGATION",
- "endDef1": {
- "type": "trino_table",
- "name": "trinoschema",
- "isContainer": false,
- "cardinality": "SINGLE",
- "isLegacyAttribute": false
- },
- "endDef2": {
- "type": "trino_schema",
- "name": "tables",
- "isContainer": true,
- "cardinality": "SET"
- },
- "propagateTags": "NONE"
+ {
+ "name": "ordinal_position",
+ "typeName": "int",
+ "isOptional": true,
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false
},
{
- "name": "trino_table_columns",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "COMPOSITION",
- "endDef1": {
- "type": "trino_table",
- "name": "columns",
- "isContainer": true,
- "cardinality": "SET",
- "isLegacyAttribute": false
- },
- "endDef2": {
- "type": "trino_column",
- "name": "table",
- "isContainer": false,
- "cardinality": "SINGLE",
- "isLegacyAttribute": false
- },
- "propagateTags": "NONE"
+ "name": "column_default",
+ "typeName": "string",
+ "isOptional": true,
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false
},
{
- "name": "trino_table_ddl_queries",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "COMPOSITION",
- "endDef1": {
- "type": "trino_table",
- "name": "ddlQueries",
- "isContainer": true,
- "cardinality": "SET"
- },
- "endDef2": {
- "type": "trino_table_ddl",
- "name": "table",
- "isContainer": false,
- "cardinality": "SINGLE"
- },
- "propagateTags": "NONE"
+ "name": "comment",
+ "typeName": "string",
+ "isOptional": true,
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false
},
{
- "name": "trino_schema_ddl_queries",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "COMPOSITION",
- "endDef1": {
- "type": "trino_schema",
- "name": "ddlQueries",
- "isContainer": true,
- "cardinality": "SET"
- },
- "endDef2": {
- "type": "trino_schema_ddl",
- "name": "db",
- "isContainer": false,
- "cardinality": "SINGLE"
- },
- "propagateTags": "NONE"
+ "name": "is_nullable",
+ "typeName": "boolean",
+ "isOptional": true,
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false
},
{
- "name": "trino_process_column_lineage",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "COMPOSITION",
- "endDef1": {
- "type": "trino_column_lineage",
- "name": "query",
- "isContainer": false,
- "cardinality": "SINGLE",
- "isLegacyAttribute": true
- },
- "endDef2": {
- "type": "trino_process",
- "name": "columnLineages",
- "isContainer": true,
- "cardinality": "SET"
- },
- "propagateTags": "NONE"
+ "name": "isPrimaryKey",
+ "typeName": "boolean",
+ "isOptional": true,
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false
+ }
+ ]
+ },
+ {
+ "name": "trino_column_lineage",
+ "superTypes": [ "Process" ],
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "attributeDefs": [
+ {
+ "name": "expression",
+ "typeName": "string",
+ "cardinality": "SINGLE",
+ "isIndexable": false,
+ "isOptional": true,
+ "isUnique": false
+ }
+ ]
+ },
+ {
+ "name": "trino_process",
+ "superTypes": [ "Process" ],
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "attributeDefs": [
+ {
+ "name": "queryId",
+ "typeName": "string",
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false,
+ "searchWeight": 5
},
- {
- "name": "trino_schema_hive_db",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "ASSOCIATION",
- "endDef1": {
- "type": "hive_db",
- "name": "trino_schema",
- "cardinality": "SET"
- },
- "endDef2": {
- "type": "trino_schema",
- "name": "hive_db",
- "cardinality": "SINGLE"
- },
- "propagateTags": "BOTH"
+ {
+ "name": "queryCreateTime",
+ "typeName": "long",
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false,
+ "searchWeight": 5
},
- {
- "name": "trino_table_hive_table",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "ASSOCIATION",
- "endDef1": {
- "type": "hive_table",
- "name": "trino_table",
- "cardinality": "SET"
- },
- "endDef2": {
- "type": "trino_table",
- "name": "hive_table",
- "cardinality": "SINGLE"
- },
- "propagateTags": "BOTH"
+ {
+ "name": "queryEndTime",
+ "typeName": "long",
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false,
+ "searchWeight": 5
},
- {
- "name": "trino_column_hive_column",
- "serviceType": "trino",
- "typeVersion": "1.0",
- "relationshipCategory": "ASSOCIATION",
- "endDef1": {
- "type": "hive_column",
- "name": "trino_column",
- "cardinality": "SET"
- },
- "endDef2": {
- "type": "trino_column",
- "name": "hive_column",
- "cardinality": "SINGLE"
- },
- "propagateTags": "BOTH"
+ {
+ "name": "queryText",
+ "typeName": "string",
+ "cardinality": "SINGLE",
+ "isUnique": false,
+ "isIndexable": false,
+ "searchWeight": 5
}
- ]
+ ]
+ },
+ {
+ "name": "trino_schema_ddl",
+ "superTypes": [ "ddl" ],
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "attributeDefs": [ ]
+ },
+ {
+ "name": "trino_table_ddl",
+ "superTypes": [ "ddl" ],
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "attributeDefs": [ ]
+ }
+ ],
+ "relationshipDefs": [
+ {
+ "name": "trino_instance_catalog",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "COMPOSITION",
+ "propagateTags": "NONE",
+ "endDef1": { "type": "trino_catalog", "name": "instance",
"isContainer": false, "cardinality": "SINGLE", "isLegacyAttribute": false },
+ "endDef2": { "type": "trino_instance", "name": "catalogs",
"isContainer": true, "cardinality": "SET" }
+ },
+ {
+ "name": "trino_schema_catalog",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "AGGREGATION",
+ "propagateTags": "NONE",
+ "endDef1": { "type": "trino_schema", "name": "catalog", "isContainer":
false, "cardinality": "SINGLE", "isLegacyAttribute": false },
+ "endDef2": { "type": "trino_catalog", "name": "schemas", "isContainer":
true, "cardinality": "SET" }
+ },
+ {
+ "name": "trino_table_schema",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "AGGREGATION",
+ "propagateTags": "NONE",
+ "endDef1": { "type": "trino_table", "name": "trinoschema",
"isContainer": false, "cardinality": "SINGLE", "isLegacyAttribute": false },
+ "endDef2": { "type": "trino_schema", "name": "tables",
"isContainer": true, "cardinality": "SET" }
+ },
+ {
+ "name": "trino_table_columns",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "COMPOSITION",
+ "propagateTags": "NONE",
+ "endDef1": { "type": "trino_table", "name": "columns", "isContainer":
true, "cardinality": "SET", "isLegacyAttribute": false },
+ "endDef2": { "type": "trino_column", "name": "table", "isContainer":
false, "cardinality": "SINGLE", "isLegacyAttribute": false }
+ },
+ {
+ "name": "trino_table_ddl_queries",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "COMPOSITION",
+ "propagateTags": "NONE",
+ "endDef1": { "type": "trino_table", "name": "ddlQueries",
"isContainer": true, "cardinality": "SET" },
+ "endDef2": { "type": "trino_table_ddl", "name": "table",
"isContainer": false, "cardinality": "SINGLE" }
+ },
+ {
+ "name": "trino_schema_ddl_queries",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "COMPOSITION",
+ "propagateTags": "NONE",
+ "endDef1": { "type": "trino_schema", "name": "ddlQueries",
"isContainer": true, "cardinality": "SET" },
+ "endDef2": { "type": "trino_schema_ddl", "name": "db",
"isContainer": false, "cardinality": "SINGLE" }
+ },
+ {
+ "name": "trino_process_column_lineage",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "COMPOSITION",
+ "propagateTags": "NONE",
+ "endDef1": { "type": "trino_column_lineage", "name": "query",
"isContainer": false, "cardinality": "SINGLE" },
+ "endDef2": { "type": "trino_process", "name": "columnLineages",
"isContainer": true, "cardinality": "SET" }
+ },
+ {
+ "name": "trino_schema_hive_db",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "ASSOCIATION",
+ "propagateTags": "BOTH",
+ "endDef1": { "type": "hive_db", "name": "trino_schema",
"cardinality": "SET" },
+ "endDef2": { "type": "trino_schema", "name": "hive_db",
"cardinality": "SINGLE" }
+ },
+ {
+ "name": "trino_table_hive_table",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "ASSOCIATION",
+ "propagateTags": "BOTH",
+ "endDef1": { "type": "hive_table", "name": "trino_table",
"cardinality": "SET" },
+ "endDef2": { "type": "trino_table", "name": "hive_table",
"cardinality": "SINGLE" }
+ },
+ {
+ "name": "trino_column_hive_column",
+ "serviceType": "trino",
+ "typeVersion": "1.0",
+ "relationshipCategory": "ASSOCIATION",
+ "propagateTags": "BOTH",
+ "endDef1": { "type": "hive_column", "name": "trino_column",
"cardinality": "SET" },
+ "endDef2": { "type": "trino_column", "name": "hive_column",
"cardinality": "SINGLE" }
+ }
+ ]
}
\ No newline at end of file
diff --git
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/cli/ExtractorService.java
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/cli/ExtractorService.java
index e4f0797cf..31d4d9950 100644
---
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/cli/ExtractorService.java
+++
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/cli/ExtractorService.java
@@ -65,7 +65,7 @@ public class ExtractorService {
trinoNamespace = context.getNamespace();
Map<String, String> catalogs = trinoClientHelper.getAllTrinoCatalogs();
- LOG.info("Found {} catalogs in Trino", catalogs.toString());
+ LOG.info("Found {} catalogs in Trino: {}", catalogs.size(),
catalogs.keySet());
try {
processCatalogs(context, catalogs);
diff --git
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/client/AtlasClientHelper.java
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/client/AtlasClientHelper.java
index 26bb95322..e9ef23260 100644
---
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/client/AtlasClientHelper.java
+++
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/client/AtlasClientHelper.java
@@ -49,17 +49,17 @@ import static
org.apache.atlas.type.AtlasTypeUtil.ATTRIBUTE_QUALIFIED_NAME;
public class AtlasClientHelper {
private static final Logger LOG =
LoggerFactory.getLogger(AtlasClientHelper.class);
- public static final String TRINO_INSTANCE =
"trino_instance";
- public static final String TRINO_CATALOG =
"trino_catalog";
- public static final String TRINO_SCHEMA =
"trino_schema";
- public static final String TRINO_TABLE =
"trino_table";
- public static final String TRINO_COLUMN =
"trino_column";
- public static final String TRINO_INSTANCE_CATALOG_ATTRIBUTE = "catalogs";
- public static final String TRINO_CATALOG_SCHEMA_ATTRIBUTE = "schemas";
- public static final String TRINO_SCHEMA_TABLE_ATTRIBUTE = "tables";
- public static final String QUALIFIED_NAME_ATTRIBUTE =
"qualifiedName";
- public static final String NAME_ATTRIBUTE = "name";
- public static final int pageLimit =
10000;
+ public static final String TRINO_INSTANCE =
"trino_instance";
+ public static final String TRINO_CATALOG =
"trino_catalog";
+ public static final String TRINO_SCHEMA =
"trino_schema";
+ public static final String TRINO_TABLE =
"trino_table";
+ public static final String TRINO_COLUMN =
"trino_column";
+ public static final String TRINO_INSTANCE_CATALOG_ATTRIBUTE =
"catalogs";
+ public static final String TRINO_CATALOG_SCHEMA_ATTRIBUTE =
"schemas";
+ public static final String TRINO_SCHEMA_TABLE_ATTRIBUTE =
"tables";
+ public static final String QUALIFIED_NAME_ATTRIBUTE =
"qualifiedName";
+ public static final String NAME_ATTRIBUTE =
"name";
+ public static final int DEFAULT_PAGE_LIMIT =
10000;
private static final String DEFAULT_ATLAS_URL =
"http://localhost:21000/";;
private static final String APPLICATION_PROPERTY_ATLAS_ENDPOINT =
"atlas.rest.address";
private static final String TRINO_CATALOG_CONNECTOR_TYPE_ATTRIBUTE =
"connectorType";
@@ -145,7 +145,7 @@ public class AtlasClientHelper {
return null;
}
List<AtlasEntityHeader> entities = new ArrayList<>();
- final int pageSize = pageLimit;
+ final int pageSize = DEFAULT_PAGE_LIMIT;
for (int i = 0; ; i++) {
int offset = pageSize * i;
diff --git
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/ConnectorFactory.java
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/ConnectorFactory.java
index e7a690e66..7495780fa 100644
---
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/ConnectorFactory.java
+++
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/ConnectorFactory.java
@@ -30,7 +30,7 @@ public class ConnectorFactory {
case "hive":
return new HiveEntityConnector();
default:
- LOG.warn("{} type does not have hook implemented on Atlas");
+ LOG.warn("{} type does not have hook implemented on Atlas",
connectorType);
return null;
}
}
diff --git
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/HiveEntityConnector.java
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/HiveEntityConnector.java
index 8e1036718..8f6f5904c 100644
---
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/HiveEntityConnector.java
+++
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/HiveEntityConnector.java
@@ -65,7 +65,7 @@ public class HiveEntityConnector extends AtlasEntityConnector
{
@Override
public void connectTrinoTable(String instanceName, String catalogName,
String schemaName, String tableName, AtlasEntity trinoTable, List<AtlasEntity>
columnEntities, AtlasEntity.AtlasEntityWithExtInfo entityWithExtInfo) {
if (instanceName == null) {
- LOG.warn("Failed attempting to entity since hook namespace is
empty, Please configure in properties");
+ LOG.warn("Failed attempting to connect entity since hook namespace
is empty, Please configure in properties");
return;
}
diff --git
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/IcebergEntityConnector.java
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/IcebergEntityConnector.java
index a48aa7ffd..5bc51795c 100644
---
a/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/IcebergEntityConnector.java
+++
b/addons/trino-extractor/src/main/java/org/apache/atlas/trino/connector/IcebergEntityConnector.java
@@ -66,7 +66,7 @@ public class IcebergEntityConnector extends
AtlasEntityConnector {
@Override
public void connectTrinoTable(String instanceName, String catalogName,
String schemaName, String tableName, AtlasEntity trinoTable, List<AtlasEntity>
columnEntities, AtlasEntity.AtlasEntityWithExtInfo entityWithExtInfo) {
if (instanceName == null) {
- LOG.warn("Failed attempting to entity since hook namespace is
empty, Please configure in properties");
+ LOG.warn("Failed attempting to connect entity since hook namespace
is empty, Please configure in properties");
return;
}
diff --git
a/addons/trino-extractor/src/test/java/org/apache/atlas/trino/cli/TrinoExtractorIT.java
b/addons/trino-extractor/src/test/java/org/apache/atlas/trino/cli/TrinoExtractorIT.java
index 4a6ef475f..7e94f381b 100644
---
a/addons/trino-extractor/src/test/java/org/apache/atlas/trino/cli/TrinoExtractorIT.java
+++
b/addons/trino-extractor/src/test/java/org/apache/atlas/trino/cli/TrinoExtractorIT.java
@@ -37,6 +37,6 @@ public class TrinoExtractorIT {
Deleted schema
Rename catalog
Rename schema
- Tag propogated*/
+ Tag propagated*/
}
