This is an automated email from the ASF dual-hosted git repository.
ppawar pushed a commit to branch atlas-2.5
in repository https://gitbox.apache.org/repos/asf/atlas.git
The following commit(s) were added to refs/heads/atlas-2.5 by this push:
new 8826eeb89 ATLAS-5077, ATLAS-5076 (#408)
8826eeb89 is described below
commit 8826eeb891302507347ab2a5c6b167b18fd66aca
Author: farhank31 <[email protected]>
AuthorDate: Thu Jul 24 12:37:44 2025 +0530
ATLAS-5077, ATLAS-5076 (#408)
Co-authored-by: Farhan Khan <[email protected]>
---
.../EntityDetailTabs/PropertiesTab/BMAttributes.tsx | 7 +++++--
.../DetailPage/EntityDetailTabs/PropertiesTab/Labels.tsx | 11 +++++++++--
.../EntityDetailTabs/PropertiesTab/UserDefinedProperties.tsx | 6 +++++-
3 files changed, 19 insertions(+), 5 deletions(-)
diff --git
a/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/BMAttributes.tsx
b/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/BMAttributes.tsx
index f116359f7..0697efdb0 100644
---
a/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/BMAttributes.tsx
+++
b/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/BMAttributes.tsx
@@ -296,7 +296,6 @@ const BMAttributes = ({ loading, bmAttributes, entity }:
any) => {
}
};
const handleSave = (e: React.MouseEvent) => {
- console.log(errors);
e.stopPropagation();
handleSubmit(onSubmit)();
};
@@ -378,6 +377,7 @@ const BMAttributes = ({ loading, bmAttributes, entity }:
any) => {
<Stack direction="row" alignItems="center" gap="0.5rem">
{addLabel ? (
<CustomButton
+ key="edit-Add-button"
variant="outlined"
color="success"
size="small"
@@ -395,17 +395,20 @@ const BMAttributes = ({ loading, bmAttributes, entity }:
any) => {
) : (
<>
<CustomButton
+ key="save-button"
variant="outlined"
color="success"
size="small"
+ disabled={isSubmitting}
onClick={handleSave}
startIcon={
- isSubmitting && <CircularProgress size="14px"
/>
+ isSubmitting && <CircularProgress size="14px"
color="inherit"/>
}
>
Save
</CustomButton>
<CustomButton
+ key="cancel-button"
variant="outlined"
color="success"
size="small"
diff --git
a/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/Labels.tsx
b/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/Labels.tsx
index f7ff1f169..73a71ac75 100644
--- a/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/Labels.tsx
+++ b/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/Labels.tsx
@@ -113,7 +113,10 @@ const Labels = ({ loading, labels }: any) => {
const onSubmit = async (values: any) => {
let formData = { ...values };
- let data = formData.labels.map((obj: { inputValue: any }) => {
+ if(isEmpty(formData.labels) && isEmpty(labels)){
+ return;
+ }
+ let data = formData.labels?.map((obj: { inputValue: any }) => {
if (obj.inputValue) {
return obj.inputValue;
}
@@ -169,6 +172,7 @@ const Labels = ({ loading, labels }: any) => {
<Stack direction="row" alignItems="center" gap="0.5rem">
{addLabel ? (
<CustomButton
+ key="edit-Add-button"
variant="outlined"
color="success"
size="small"
@@ -183,17 +187,20 @@ const Labels = ({ loading, labels }: any) => {
) : (
<>
<CustomButton
+ key="save-button"
variant="outlined"
color="success"
size="small"
onClick={handleSave}
+ disabled={isSubmitting}
startIcon={
- isSubmitting && <CircularProgress size="14px" />
+ isSubmitting && <CircularProgress size="14px"
color="inherit"/>
}
>
Save
</CustomButton>
<CustomButton
+ key="cancel-button"
variant="outlined"
color="success"
size="small"
diff --git
a/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/UserDefinedProperties.tsx
b/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/UserDefinedProperties.tsx
index e5f0ca839..b04a72d6c 100644
---
a/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/UserDefinedProperties.tsx
+++
b/dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/UserDefinedProperties.tsx
@@ -183,6 +183,7 @@ const UserDefinedProperties = ({ loading, customAttributes,
entity }: any) => {
<Stack direction="row" alignItems="center" gap="0.5rem">
{addLabel ? (
<CustomButton
+ key="edit-Add-button"
variant="outlined"
color="success"
size="small"
@@ -200,17 +201,20 @@ const UserDefinedProperties = ({ loading,
customAttributes, entity }: any) => {
) : (
<>
<CustomButton
+ key="save-button"
variant="outlined"
color="success"
size="small"
+ disabled={isSubmitting}
onClick={handleSave}
startIcon={
- isSubmitting && <CircularProgress size="14px" />
+ isSubmitting && <CircularProgress size="14px"
color="inherit"/>
}
>
Save
</CustomButton>
<CustomButton
+ key="cancel-button"
variant="outlined"
color="success"
size="small"
