XD-DENG commented on issue #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint URL: https://github.com/apache/incubator-airflow/pull/4309#issuecomment-448243755 Thanks @kaxil . It's a good point to standardise the response. Will follow your suggestion. Will updte the documentation as well. Regarding exposing details in this health check response, I'm a bit conservative. For example, the `open_connections` in the sample you gave should only be exposed to someone with Admin privilege (or at least logged-in users). In short, maybe we want to avoid exposing too much information here given no authentication is needed to access this endpoint. I would like to propose ``` { "scheduler": { "status": "healthy", "latest_scheduler_run": "2018-12-26 17:15:11+00:00" }, "webserver": { "status": "healthy" }, "metadatabase": { "status": "healthy" } } ``` - Status of `metadatabase`: decided by if a simple query can succeed or not. - Status of `scheduler`: decided by `current_time_stamp - latest_scheduler_run >= 30 seconds`. If `True`, scheduler is "unhealthy"; if `False`, scheduler is "healthy". Please advise if this threshold (30 sec) makes sense or should it be smaller? (@ashb please advise as well) Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
