[ 
https://issues.apache.org/jira/browse/AIRFLOW-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723496#comment-16723496
 ] 

ASF GitHub Bot commented on AIRFLOW-1844:
-----------------------------------------

stale[bot] closed pull request #2811: [AIRFLOW-1844] task would not be executed 
when celery broker recovery
URL: https://github.com/apache/incubator-airflow/pull/2811
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/airflow/executors/base_executor.py 
b/airflow/executors/base_executor.py
index d3d0675ee4..da2a7827ab 100644
--- a/airflow/executors/base_executor.py
+++ b/airflow/executors/base_executor.py
@@ -120,8 +120,8 @@ def heartbeat(self):
             self.queued_tasks.pop(key)
             ti.refresh_from_db()
             if ti.state != State.RUNNING:
-                self.running[key] = command
                 self.execute_async(key, command=command, queue=queue)
+                self.running[key] = command
             else:
                 self.log.debug(
                     'Task is already running, not sending to executor: %s',


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> task would not be executed when celery broker recovery
> ------------------------------------------------------
>
>                 Key: AIRFLOW-1844
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1844
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: celery, executor, scheduler
>    Affects Versions: 1.8.0, 1.9.0
>            Reporter: hujiahua
>            Priority: Major
>
> When the scheduler fail to send task during celery broker not working, then 
> the task will never send again and never be executed when celery broker 
> recovery.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to