[
https://issues.apache.org/jira/browse/AIRFLOW-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720481#comment-16720481
]
ASF GitHub Bot commented on AIRFLOW-2770:
-----------------------------------------
kppullin opened a new pull request #4319: [AIRFLOW-2770] Read `dags_in_image`
config value as a boolean
URL: https://github.com/apache/incubator-airflow/pull/4319
This PR is a minor fix for #3683
The `dags_in_image` config value is read as a string. However, the existing
code expects this to be a boolean.
For example, in `worker_configuration.py` there is the statement: `if not
self.kube_config.dags_in_image:`
Since the value is a non-empty string ('False') and not a boolean, this
evaluates to true (since non-empty strings are truthy)
and skips the logic to add the `dags_volume_claim` volume mount.
This results in the CI tests failing because the dag volume is missing in
the k8s pod definition.
This PR reads the `dags_in_image` using the `conf.getboolean` to fix this
error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> kubernetes: add support for dag folder in the docker image
> ----------------------------------------------------------
>
> Key: AIRFLOW-2770
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2770
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Rurui Ye
> Assignee: Rurui Ye
> Priority: Critical
> Fix For: 1.10.2
>
>
> currently the kube executor need to provider dag_volume_chain or git repo in
> the config file, but if the user has build dag into their docker image, they
> doesn't need to provider these two options, and they can manager their dag
> version by manager the docker image version.
> So I suppose we can add the a new configuration as
> kube.config.dag_folder_path along with dag_volume_chain and git repo. with
> this config, we can run the worker just from the dags in docker image.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
