[
https://issues.apache.org/jira/browse/AIRFLOW-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720093#comment-16720093
]
ASF GitHub Bot commented on AIRFLOW-1381:
-----------------------------------------
chhantyal opened a new pull request #4315: [AIRFLOW-1381] Specify host
temporary directory
URL: https://github.com/apache/incubator-airflow/pull/4315
Allow user to specify temporary directory to use on the host machine;
default settings will cause an error on OS X due to the standard
temporary directory not being shared to Docker.
This is updated PR for https://github.com/apache/incubator-airflow/pull/2418
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
JIRA
My PR addresses the following Airflow JIRA issues and references them in
the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
https://issues.apache.org/jira/browse/AIRFLOW-1381
Description
Here are some details about my PR, including screenshots of any UI
changes:
DockerOperator currently uses the standard TemporaryDirectory helper, which
calls the standard libary. On OS X the default directory cannot be shared to
Docker containers. This PR allows the host temporary directory to be specified
by the user.
Tests
My PR adds the following unit tests OR does not need testing for this
extremely good reason:
Added a test into docker_operator to ensure that mkdtemp is called correctly.
Commits
My commits all reference JIRA issues in their subject lines, and I have
squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> DockerOperator does not allow specification of temporary directory on host
> --------------------------------------------------------------------------
>
> Key: AIRFLOW-1381
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1381
> Project: Apache Airflow
> Issue Type: Improvement
> Components: docker, operators
> Affects Versions: 1.9.0
> Environment: Causes failure under default conditions in OS X
> Reporter: Benjamin Sims
> Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The Docker uses the standard TemporaryDirectory mechanism to add a volume to
> the container which is mapped to a temporary directory on the host.
> By default, TemporaryDirectory places this in a location such as
> /var/folders/xxx/xxxxx/T/airflowtmpyi9pnn6w.
> However, Docker on OS X only allows certain folders to be shared into a
> container. /var/folders is not shared on OS X (and cannot be shared) and the
> operator will therefore fail with a 'Mounts denied' message.
> This can be solved by setting the environment variable TMPDIR to a path which
> Docker is able to share. However a solution to set this in the Operator
> itself would also be useful.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
