dlamblin commented on a change in pull request #4163: [AIRFLOW-3319] -
KubernetsExecutor: Need in try_number in labels if getting them later
URL: https://github.com/apache/incubator-airflow/pull/4163#discussion_r240276007
##########
File path: airflow/contrib/executors/kubernetes_executor.py
##########
@@ -346,6 +346,7 @@ def run_next(self, next_job):
namespace=self.namespace, worker_uuid=self.worker_uuid,
pod_id=self._create_pod_id(dag_id, task_id),
dag_id=dag_id, task_id=task_id,
+ try_number=try_number,
Review comment:
Since you're not breaking all the arguments into their own line (with
redundant comma) 349 could have been appended to 348 without exceeding line
length.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services