ashb commented on a change in pull request #2412: AIRFLOW-1216 introducing notifiers URL: https://github.com/apache/incubator-airflow/pull/2412#discussion_r240144176
########## File path: airflow/config_templates/default_test.cfg ########## @@ -60,6 +60,12 @@ hide_paused_dags_by_default = False [email] email_backend = airflow.utils.email.send_email_smtp +[hipchat] +token = 42 Review comment: These should be connection_ids, not the direct token as these are effectively passwords and we don't want them "in-the-plain" in the config file. Or alternatively add support for `token_cmd` to run a command to get these values. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
