MarcusSorealheis commented on issue #4295: AIRFLOW-3452 removed an 
unused/dangerous display-none
URL: 
https://github.com/apache/incubator-airflow/pull/4295#issuecomment-445407824
 
 
   Furthermore @OldPanda, `display:none`, though not nearly as dangerous or 
comprisable as something like `eval` on the front end, it should still be 
wholly avoided. One of the reasons we should avoid it is because `display:none` 
[hides all its child text from screen readers] 
(https://css-tricks.com/places-its-tempting-to-use-display-none-but-dont/) and 
that's bad. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to